Do not allow null values for first argument in type resolution

Author: timgrein

x-pack/plugin/esql/src/main/java/org/elasticsearch/xpack/esql/expression/function/fulltext/Decay.java

@@ -43,6 +43,7 @@
 import java.util.List;
 
 import static org.elasticsearch.xpack.esql.core.expression.TypeResolutions.ParamOrdinal.*;
+import static org.elasticsearch.xpack.esql.core.expression.TypeResolutions.isNotNull;
 import static org.elasticsearch.xpack.esql.core.expression.TypeResolutions.isNumeric;
 import static org.elasticsearch.xpack.esql.core.expression.TypeResolutions.isType;
 import static org.elasticsearch.xpack.esql.core.type.DataType.*;
@@ -165,13 +166,14 @@ protected TypeResolution resolveType() {
             return new TypeResolution("Unresolved children");
         }
 
-        TypeResolution valueResolution = isType(
+        TypeResolution valueResolution = isNotNull(value, sourceText(), FIRST)
+            .and(isType(
             value,
             dt -> dt.isNumeric() || dt.isDate() || isSpatialPoint(dt),
             sourceText(),
             FIRST,
             NUMERIC_DATE_OR_SPATIAL_POINT
-        );
+        ));
         if (valueResolution.unresolved()) {
             return valueResolution;
         }
@@ -392,7 +394,6 @@ static double process(double value, double origin, double scale, double offset,
         };
     }
 
-    // TODO: should offset be a long?
     @Evaluator(extraName = "Long")
     static double process(long value, long origin, long scale, double offset, double decay, BytesRef functionType) {
         return switch (functionType.utf8ToString()) {

x-pack/plugin/esql/src/test/java/org/elasticsearch/xpack/esql/expression/function/fulltext/DecayTests.java

@@ -31,6 +31,7 @@
 import static org.hamcrest.Matchers.equalTo;
 import static org.hamcrest.Matchers.startsWith;
 
+// TODO: check null args in VerifierTests
 public class DecayTests extends AbstractScalarFunctionTestCase {
 
     public DecayTests(@Name("TestCase") Supplier<TestCaseSupplier.TestCase> testCaseSupplier) {
@@ -149,7 +150,7 @@ public static Iterable<Object[]> parameters() {
             )
         );
 
-        return parameterSuppliersFromTypedDataWithDefaultChecksNoErrors(true, testCaseSuppliers);
+        return parameterSuppliersFromTypedData(testCaseSuppliers);
     }
 
     @Override