Skip to content

Commit 64cf052

Browse files
authored
Remove AwaitFix HeapAttack tests in 8.11 (#103154)
We've made some improvements in memory tracking in ESQL, but due to their complexity, we intentionally chose not to backport them to 8.11. Without these enhancements, some HeapAttack tests are not ready for 8.11. I think we should remove the AwaitsFix tests and focus on 8.13 instead. Closes #100640
1 parent 7de781d commit 64cf052

File tree

1 file changed

+0
-33
lines changed
  • x-pack/plugin/esql/qa/server/heap-attack/src/javaRestTest/java/org/elasticsearch/xpack/esql/qa/heap_attack

1 file changed

+0
-33
lines changed

x-pack/plugin/esql/qa/server/heap-attack/src/javaRestTest/java/org/elasticsearch/xpack/esql/qa/heap_attack/HeapAttackIT.java

Lines changed: 0 additions & 33 deletions
Original file line numberDiff line numberDiff line change
@@ -110,21 +110,6 @@ public void testGroupOnSomeLongs() throws IOException {
110110
assertMap(map, matchesMap().entry("columns", columns).entry("values", values));
111111
}
112112

113-
/**
114-
* This groups on 5000 columns which used to throw a {@link StackOverflowError}.
115-
*/
116-
public void testGroupOnManyLongs() throws IOException {
117-
initManyLongs();
118-
Map<?, ?> map = XContentHelper.convertToMap(
119-
JsonXContent.jsonXContent,
120-
EntityUtils.toString(groupOnManyLongs(5000).getEntity()),
121-
false
122-
);
123-
ListMatcher columns = matchesList().item(matchesMap().entry("name", "MAX(a)").entry("type", "long"));
124-
ListMatcher values = matchesList().item(List.of(9));
125-
assertMap(map, matchesMap().entry("columns", columns).entry("values", values));
126-
}
127-
128113
private Response groupOnManyLongs(int count) throws IOException {
129114
logger.info("grouping on {} longs", count);
130115
StringBuilder query = makeManyLongs(count);
@@ -247,12 +232,6 @@ public void testManyEval() throws IOException {
247232
assertMap(map, matchesMap().entry("columns", columns).entry("values", hasSize(10_000)));
248233
}
249234

250-
@AwaitsFix(bugUrl = "https://github.com/elastic/elasticsearch/issues/100528")
251-
public void testTooManyEval() throws IOException {
252-
initManyLongs();
253-
assertCircuitBreaks(() -> manyEval(1000));
254-
}
255-
256235
private Response manyEval(int evalLines) throws IOException {
257236
StringBuilder query = new StringBuilder();
258237
query.append("{\"query\":\"FROM manylongs");
@@ -289,12 +268,6 @@ public void testFetchManyBigFields() throws IOException {
289268
fetchManyBigFields(100);
290269
}
291270

292-
@AwaitsFix(bugUrl = "https://github.com/elastic/elasticsearch/issues/100528")
293-
public void testFetchTooManyBigFields() throws IOException {
294-
initManyBigFieldsIndex(500);
295-
assertCircuitBreaks(() -> fetchManyBigFields(500));
296-
}
297-
298271
/**
299272
* Fetches documents containing 1000 fields which are {@code 1kb} each.
300273
*/
@@ -345,12 +318,6 @@ public void testFetchMvLongs() throws IOException {
345318
assertMap(map, matchesMap().entry("columns", columns));
346319
}
347320

348-
@AwaitsFix(bugUrl = "https://github.com/elastic/elasticsearch/issues/100528")
349-
public void testFetchTooManyMvLongs() throws IOException {
350-
initMvLongsIndex(500, 100, 1000);
351-
assertCircuitBreaks(() -> fetchMvLongs());
352-
}
353-
354321
private Response fetchMvLongs() throws IOException {
355322
return query("{\"query\": \"FROM mv_longs\"}", "columns");
356323
}

0 commit comments

Comments
 (0)