testing in an internalClusterTest rather than a yaml test to avoid adding a NodeFeature

Author: masseyke

rest-api-spec/src/yamlRestTest/resources/rest-api-spec/test/indices.put_settings/20_update_non_dynamic_settings.yml

@@ -55,74 +55,3 @@ setup:
         flat_settings: false
   - match:
       test-index.settings.index.codec: "best_compression"
-
----
-"Test update non dynamic settings on multiple indices":
-  - do:
-      indices.create:
-        index: test-index-1
-        body:
-          settings:
-            index:
-              number_of_replicas: 0
-
-  - do:
-      indices.create:
-        index: test-index-2
-        body:
-          settings:
-            index:
-              number_of_replicas: 0
-
-  - do:
-      indices.put_settings:
-        index: test-index-1
-        body:
-          number_of_replicas: 1
-
-  - do:
-      indices.put_settings:
-        index: test-index-2
-        body:
-          number_of_replicas: 1
-
-  - do:
-      catch: bad_request
-      indices.put_settings:
-        index: test-index-*
-        body:
-          index.codec: best_compression
-
-  - do:
-      catch: bad_request
-      indices.put_settings:
-        index: test-index-*
-        reopen: false
-        body:
-          index.codec: best_compression
-
-  - do:
-      indices.get_settings:
-        index: test-index-*
-        flat_settings: false
-  - match:
-      test-index-1.settings.index.codec: null
-  - match:
-      test-index-2.settings.index.codec: null
-
-  - do:
-      indices.put_settings:
-        index: test-index-*
-        reopen: true
-        body:
-          index.codec: best_compression
-  - match: { acknowledged: true }
-
-  - do:
-      indices.get_settings:
-        index: test-index-*
-        flat_settings: false
-  - match:
-      test-index-1.settings.index.codec: "best_compression"
-  - match:
-      test-index-2.settings.index.codec: "best_compression"

server/src/internalClusterTest/java/org/elasticsearch/cluster/metadata/MetadataUpdateSettingsServiceIT.java

@@ -39,7 +39,8 @@ public void testThatNonDynamicSettingChangesTakeEffect() throws Exception {
          * This test makes sure that when non-dynamic settings are updated that they actually take effect (as opposed to just being set
          * in the cluster state).
          */
-        createIndex("test", Settings.EMPTY);
+        createIndex("test-1", Settings.EMPTY);
+        createIndex("test-2", Settings.EMPTY);
         MetadataUpdateSettingsService metadataUpdateSettingsService = internalCluster().getCurrentMasterNodeInstance(
             MetadataUpdateSettingsService.class
         );