fixing the build

Author: masseyke

server/src/main/java/org/elasticsearch/action/admin/indices/settings/put/TransportUpdateSettingsAction.java

@@ -139,7 +139,11 @@ protected void masterOperation(
             listener.onFailure(new IllegalStateException(message));
             return;
         }
-        List<String> dataStreamNames = indexNameExpressionResolver.dataStreamNames(state, IndicesOptions.DEFAULT, request.indices());
+        List<String> dataStreamNames = indexNameExpressionResolver.dataStreamNames(
+            state,
+            IndicesOptions.lenientExpandOpenHidden(),
+            request.indices()
+        );
         metadataDataStreamsService.updateSettings(projectResolver, request, dataStreamNames, requestSettings, new ActionListener<>() {
             @Override
             public void onResponse(AcknowledgedResponse acknowledgedResponse) {

server/src/main/java/org/elasticsearch/cluster/metadata/DataStream.java

@@ -203,6 +203,9 @@ public DataStream(
             : "replicated data streams cannot be marked for lazy rollover";
         this.backingIndices = backingIndices;
         this.failureIndices = failureIndices;
+        if (indexTemplateOverrides != null && indexTemplateOverrides.indexPatterns() == null) {
+            throw new RuntimeException("Here i am");
+        }
     }
 
     public static DataStream read(StreamInput in) throws IOException {

server/src/main/java/org/elasticsearch/cluster/metadata/MetadataDataStreamsService.java

@@ -509,7 +509,7 @@ public void updateSettings(
             listener.onResponse(AcknowledgedResponse.TRUE);
             return;
         }
-        clusterService.submitUnbatchedStateUpdateTask(
+        submitUnbatchedTask(
             "updating settings on data streams [" + String.join(", ", dataStreamNames) + "]",
             new AckedClusterStateUpdateTask(Priority.HIGH, request.masterNodeTimeout(), request.ackTimeout(), listener) {
                 @Override
@@ -534,6 +534,7 @@ public ClusterState execute(ClusterState currentState) {
                         // Currently, the only thing we support having in template overrides is settings:
                         ComposableIndexTemplate indexTemplateOverrides = ComposableIndexTemplate.builder()
                             .template(Template.builder().settings(mergedSettingsBuilder))
+                            .indexPatterns(List.of())
                             .build();
                         DataStream.Builder dataStreamBuilder = dataStream.copy().setIndexTemplateOverrides(indexTemplateOverrides);
                         projectMetadataBuilder.removeDataStream(dataStreamName);

server/src/test/java/org/elasticsearch/action/admin/indices/settings/put/TransportUpdateSettingsActionTests.java

@@ -16,6 +16,7 @@
 import org.elasticsearch.cluster.ClusterState;
 import org.elasticsearch.cluster.metadata.IndexMetadata;
 import org.elasticsearch.cluster.metadata.IndexNameExpressionResolver;
+import org.elasticsearch.cluster.metadata.MetadataDataStreamsService;
 import org.elasticsearch.cluster.metadata.MetadataUpdateSettingsService;
 import org.elasticsearch.cluster.metadata.ProjectId;
 import org.elasticsearch.cluster.metadata.ProjectMetadata;
@@ -72,6 +73,7 @@ public void setUp() throws Exception {
 
         final ThreadPool threadPool = mock(ThreadPool.class);
         TransportService transportService = MockUtils.setupTransportServiceWithThreadpoolExecutor(threadPool);
+        MetadataDataStreamsService metadataDataStreamsService = mock(MetadataDataStreamsService.class);
         this.action = new TransportUpdateSettingsAction(
             transportService,
             mock(ClusterService.class),
@@ -80,7 +82,8 @@ public void setUp() throws Exception {
             mock(ActionFilters.class),
             projectResolver,
             indexNameExpressionResolver,
-            SYSTEM_INDICES
+            SYSTEM_INDICES,
+            metadataDataStreamsService
         );
     }
 

server/src/test/java/org/elasticsearch/cluster/metadata/DataStreamTests.java

@@ -2085,6 +2085,7 @@ public void testXContentSerializationWithRolloverAndEffectiveRetention() throws
             indices,
             generation,
             metadata,
+            null,
             isSystem,
             randomBoolean(),
             isSystem,
@@ -2279,6 +2280,7 @@ public void testWriteFailureIndex() {
             randomNonEmptyIndexInstances(),
             randomNonNegativeInt(),
             null,
+            null,
             hidden,
             replicated,
             system,
@@ -2297,6 +2299,7 @@ public void testWriteFailureIndex() {
             randomNonEmptyIndexInstances(),
             randomNonNegativeInt(),
             null,
+            null,
             hidden,
             replicated,
             system,
@@ -2322,6 +2325,7 @@ public void testWriteFailureIndex() {
             randomNonEmptyIndexInstances(),
             randomNonNegativeInt(),
             null,
+            null,
             hidden,
             replicated,
             system,
@@ -2346,6 +2350,7 @@ public void testIsFailureIndex() {
             backingIndices,
             randomNonNegativeInt(),
             null,
+            null,
             hidden,
             replicated,
             system,
@@ -2368,6 +2373,7 @@ public void testIsFailureIndex() {
             backingIndices,
             randomNonNegativeInt(),
             null,
+            null,
             hidden,
             replicated,
             system,
@@ -2399,6 +2405,7 @@ public void testIsFailureIndex() {
             backingIndices,
             randomNonNegativeInt(),
             null,
+            null,
             hidden,
             replicated,
             system,

server/src/test/java/org/elasticsearch/indices/cluster/ClusterStateChanges.java

@@ -52,11 +52,13 @@
 import org.elasticsearch.cluster.coordination.JoinTask;
 import org.elasticsearch.cluster.coordination.NodeJoinExecutor;
 import org.elasticsearch.cluster.coordination.NodeLeftExecutor;
+import org.elasticsearch.cluster.metadata.DataStreamGlobalRetentionSettings;
 import org.elasticsearch.cluster.metadata.IndexMetadata;
 import org.elasticsearch.cluster.metadata.IndexMetadataVerifier;
 import org.elasticsearch.cluster.metadata.IndexNameExpressionResolver;
 import org.elasticsearch.cluster.metadata.Metadata;
 import org.elasticsearch.cluster.metadata.MetadataCreateIndexService;
+import org.elasticsearch.cluster.metadata.MetadataDataStreamsService;
 import org.elasticsearch.cluster.metadata.MetadataDeleteIndexService;
 import org.elasticsearch.cluster.metadata.MetadataIndexStateService;
 import org.elasticsearch.cluster.metadata.MetadataIndexStateServiceUtils;
@@ -335,6 +337,11 @@ public IndexMetadata verifyIndexMetadata(
             indexNameExpressionResolver,
             destructiveOperations
         );
+        MetadataDataStreamsService metadataDataStreamsService = new MetadataDataStreamsService(
+            clusterService,
+            indicesService,
+            DataStreamGlobalRetentionSettings.create(clusterSettings)
+        );
         transportUpdateSettingsAction = new TransportUpdateSettingsAction(
             transportService,
             clusterService,
@@ -343,7 +350,8 @@ public IndexMetadata verifyIndexMetadata(
             actionFilters,
             TestProjectResolvers.DEFAULT_PROJECT_ONLY,
             indexNameExpressionResolver,
-            EmptySystemIndices.INSTANCE
+            EmptySystemIndices.INSTANCE,
+            metadataDataStreamsService
         );
         transportClusterRerouteAction = new TransportClusterRerouteAction(
             transportService,

x-pack/plugin/core/src/internalClusterTest/java/org/elasticsearch/xpack/core/action/DataStreamLifecycleUsageTransportActionIT.java

@@ -176,6 +176,7 @@ public void testAction() throws Exception {
                     indices,
                     randomLongBetween(0, 1000),
                     Map.of(),
+                    null,
                     systemDataStream || randomBoolean(),
                     replicated,
                     systemDataStream,

x-pack/plugin/deprecation/src/test/java/org/elasticsearch/xpack/deprecation/DataStreamDeprecationCheckerTests.java

@@ -174,6 +174,7 @@ private DataStream createTestDataStream(
             allIndices,
             randomNegativeLong(),
             Map.of(),
+            null,
             randomBoolean(),
             false,
             false,
@@ -264,6 +265,7 @@ public void testOldIndicesIgnoredWarningCheck() {
             allIndices,
             randomNegativeLong(),
             Map.of(),
+            null,
             randomBoolean(),
             false,
             false,
@@ -331,6 +333,7 @@ public void testOldSystemDataStreamIgnored() {
             allIndices,
             randomNegativeLong(),
             Map.of(),
+            null,
             true,
             false,
             true,

x-pack/plugin/deprecation/src/test/java/org/elasticsearch/xpack/deprecation/IndexDeprecationCheckerTests.java

@@ -216,6 +216,7 @@ public void testOldIndicesCheckDataStreamIndex() {
             List.of(indexMetadata.getIndex()),
             randomNegativeLong(),
             Map.of(),
+            null,
             randomBoolean(),
             false,
             false,