fix bad serialization

john-wagster · john-wagster · commit 674466ceb842 · 2025-09-02T21:29:55.000-05:00
diff --git a/server/src/main/java/org/elasticsearch/search/vectors/KnnSearchBuilder.java b/server/src/main/java/org/elasticsearch/search/vectors/KnnSearchBuilder.java
@@ -601,7 +601,7 @@ public void writeTo(StreamOutput out) throws IOException {
         out.writeVInt(k);
         out.writeVInt(numCands);
         if (out.getTransportVersion().onOrAfter(TransportVersions.VISIT_PERCENTAGE)) {
-            out.writeFloat(visitPercentage);
+            out.writeOptionalFloat(visitPercentage);
         }
         if (out.getTransportVersion().onOrAfter(TransportVersions.V_8_14_0)) {
             out.writeOptionalWriteable(queryVector);

Original file line number	Diff line number	Diff line change
`@@ -601,7 +601,7 @@ public void writeTo(StreamOutput out) throws IOException {`
`601`	`601`	`out.writeVInt(k);`
`602`	`602`	`out.writeVInt(numCands);`
`603`	`603`	`if (out.getTransportVersion().onOrAfter(TransportVersions.VISIT_PERCENTAGE)) {`
`604`		`- out.writeFloat(visitPercentage);`
	`604`	`+ out.writeOptionalFloat(visitPercentage);`
`605`	`605`	`}`
`606`	`606`	`if (out.getTransportVersion().onOrAfter(TransportVersions.V_8_14_0)) {`
`607`	`607`	`out.writeOptionalWriteable(queryVector);`