[ML] Fix ModelRegistryMetadataTests (#125756)

Author: davidkyle

muted-tests.yml

@@ -338,12 +338,9 @@ tests:
 - class: org.elasticsearch.index.shard.StoreRecoveryTests
   method: testAddIndices
   issue: https://github.com/elastic/elasticsearch/issues/124104
-- class: org.elasticsearch.xpack.inference.registry.ModelRegistryMetadataTests
-  method: testUpgrade
-  issue: https://github.com/elastic/elasticsearch/issues/125554
-- class: org.elasticsearch.xpack.inference.registry.ModelRegistryMetadataTests
-  method: testAlreadyUpgraded
-  issue: https://github.com/elastic/elasticsearch/issues/125585
+- class: org.elasticsearch.xpack.esql.parser.StatementParserTests
+  method: testInvalidJoinPatterns
+  issue: https://github.com/elastic/elasticsearch/issues/125536
 - class: org.elasticsearch.xpack.security.authz.accesscontrol.IndicesPermissionTests
   method: testAuthorizeDataStreamFailureIndices
   issue: https://github.com/elastic/elasticsearch/issues/125555

x-pack/plugin/inference/src/test/java/org/elasticsearch/xpack/inference/registry/ModelRegistryMetadataTests.java

@@ -30,7 +30,7 @@ public static ModelRegistryMetadata randomInstance() {
     }
 
     public static ModelRegistryMetadata randomInstance(boolean isUpgraded) {
-        if (rarely()) {
+        if (rarely() && isUpgraded == false) {
             return ModelRegistryMetadata.EMPTY;
         }
         int size = randomIntBetween(1, 5);