Remove duplicate task dependency declaration of test tasks and check

Author: breskeby

build-tools-internal/src/main/java/org/elasticsearch/gradle/internal/test/rest/InternalJavaRestTestPlugin.java

@@ -10,11 +10,8 @@
 package org.elasticsearch.gradle.internal.test.rest;
 
 import org.elasticsearch.gradle.util.GradleUtils;
-import org.gradle.api.Action;
 import org.gradle.api.Plugin;
 import org.gradle.api.Project;
-import org.gradle.api.plugins.JavaBasePlugin;
-import org.gradle.api.plugins.jvm.JvmTestSuiteTarget;
 import org.gradle.api.tasks.SourceSet;
 import org.gradle.testing.base.TestingExtension;
 
@@ -30,7 +27,6 @@ public class InternalJavaRestTestPlugin implements Plugin<Project> {
     @Override
     public void apply(Project project) {
         project.getPluginManager().apply(RestTestBasePlugin.class);
-
         TestingExtension testing = project.getExtensions().getByType(TestingExtension.class);
         testing.getSuites().registerBinding(JavaRestTestSuite.class, DefaultJavaRestTestSuite.class);
         testing.getSuites().register(SOURCE_SET_NAME, JavaRestTestSuite.class, suite -> {
@@ -39,13 +35,6 @@ public void apply(Project project) {
             if (project.findProject(":test:test-clusters") != null) {
                 suite.getDependencies().getImplementation().add(suite.getDependencies().project(":test:test-clusters"));
             }
-            suite.getTargets()
-                .all(
-                    (Action<JvmTestSuiteTarget>) jvmTestSuiteTarget -> jvmTestSuiteTarget.getTestTask()
-                        .configure(
-                            test -> project.getTasks().named(JavaBasePlugin.CHECK_TASK_NAME).configure(check -> check.dependsOn(test))
-                        )
-                );
         });
 
     }

build-tools-internal/src/main/java/org/elasticsearch/gradle/internal/test/rest/InternalYamlRestTestPlugin.java

@@ -10,11 +10,8 @@
 package org.elasticsearch.gradle.internal.test.rest;
 
 import org.elasticsearch.gradle.util.GradleUtils;
-import org.gradle.api.Action;
 import org.gradle.api.Plugin;
 import org.gradle.api.Project;
-import org.gradle.api.plugins.JavaBasePlugin;
-import org.gradle.api.plugins.jvm.JvmTestSuiteTarget;
 import org.gradle.api.tasks.SourceSet;
 import org.gradle.testing.base.TestingExtension;
 
@@ -36,13 +33,6 @@ public void apply(Project project) {
         testing.getSuites().register(SOURCE_SET_NAME, YamlRestTestSuite.class, suite -> {
             suite.useJUnit();
             configureYamlSourceSet(project, suite.getSources());
-            suite.getTargets()
-                .all(
-                    (Action<JvmTestSuiteTarget>) jvmTestSuiteTarget -> jvmTestSuiteTarget.getTestTask()
-                        .configure(
-                            test -> project.getTasks().named(JavaBasePlugin.CHECK_TASK_NAME).configure(check -> check.dependsOn(test))
-                        )
-                );
         });
     }