Skip to content

Commit 69fbbd5

Browse files
Remove extraction of unused fields from IbmWatsonxRerankServiceSettings
1 parent 522a28e commit 69fbbd5

File tree

1 file changed

+0
-9
lines changed

1 file changed

+0
-9
lines changed

x-pack/plugin/inference/src/main/java/org/elasticsearch/xpack/inference/services/ibmwatsonx/rerank/IbmWatsonxRerankServiceSettings.java

Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -27,15 +27,11 @@
2727
import java.util.Map;
2828
import java.util.Objects;
2929

30-
import static org.elasticsearch.xpack.inference.services.ServiceFields.DIMENSIONS;
31-
import static org.elasticsearch.xpack.inference.services.ServiceFields.MAX_INPUT_TOKENS;
3230
import static org.elasticsearch.xpack.inference.services.ServiceFields.MODEL_ID;
3331
import static org.elasticsearch.xpack.inference.services.ServiceFields.URL;
3432
import static org.elasticsearch.xpack.inference.services.ServiceUtils.convertToUri;
3533
import static org.elasticsearch.xpack.inference.services.ServiceUtils.createUri;
3634
import static org.elasticsearch.xpack.inference.services.ServiceUtils.extractRequiredString;
37-
import static org.elasticsearch.xpack.inference.services.ServiceUtils.extractSimilarity;
38-
import static org.elasticsearch.xpack.inference.services.ServiceUtils.removeAsType;
3935
import static org.elasticsearch.xpack.inference.services.ibmwatsonx.IbmWatsonxServiceFields.API_VERSION;
4036
import static org.elasticsearch.xpack.inference.services.ibmwatsonx.IbmWatsonxServiceFields.PROJECT_ID;
4137

@@ -56,11 +52,6 @@ public static IbmWatsonxRerankServiceSettings fromMap(Map<String, Object> map, C
5652
URI uri = convertToUri(url, URL, ModelConfigurations.SERVICE_SETTINGS, validationException);
5753
String apiVersion = extractRequiredString(map, API_VERSION, ModelConfigurations.SERVICE_SETTINGS, validationException);
5854

59-
// We need to extract/remove those fields to avoid unknown service settings errors
60-
extractSimilarity(map, ModelConfigurations.SERVICE_SETTINGS, validationException);
61-
removeAsType(map, DIMENSIONS, Integer.class);
62-
removeAsType(map, MAX_INPUT_TOKENS, Integer.class);
63-
6455
String modelId = extractRequiredString(map, MODEL_ID, ModelConfigurations.SERVICE_SETTINGS, validationException);
6556
String projectId = extractRequiredString(map, PROJECT_ID, ModelConfigurations.SERVICE_SETTINGS, validationException);
6657

0 commit comments

Comments
 (0)