Skip to content

Commit 6a4292a

Browse files
committed
Pass ModuleEntitlements to notEntitled
1 parent ebd8be0 commit 6a4292a

File tree

1 file changed

+9
-11
lines changed
  • libs/entitlement/src/main/java/org/elasticsearch/entitlement/runtime/policy

1 file changed

+9
-11
lines changed

libs/entitlement/src/main/java/org/elasticsearch/entitlement/runtime/policy/PolicyManager.java

Lines changed: 9 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -265,17 +265,17 @@ private void neverEntitled(Class<?> callerClass, Supplier<String> operationDescr
265265
return;
266266
}
267267

268-
String componentName = getEntitlements(requestingClass).componentName();
268+
ModuleEntitlements entitlements = getEntitlements(requestingClass);
269269
notEntitled(
270270
Strings.format(
271271
"component [%s], module [%s], class [%s], operation [%s]",
272-
componentName,
272+
entitlements.componentName(),
273273
requestingClass.getModule().getName(),
274274
requestingClass,
275275
operationDescription.get()
276276
),
277277
callerClass,
278-
componentName
278+
entitlements
279279
);
280280
}
281281

@@ -393,7 +393,7 @@ public void checkFileRead(Class<?> callerClass, Path path, boolean followLinks)
393393
realPath == null ? path : Strings.format("%s -> %s", path, realPath)
394394
),
395395
callerClass,
396-
entitlements.componentName()
396+
entitlements
397397
);
398398
}
399399
}
@@ -423,7 +423,7 @@ public void checkFileWrite(Class<?> callerClass, Path path) {
423423
path
424424
),
425425
callerClass,
426-
entitlements.componentName()
426+
entitlements
427427
);
428428
}
429429
}
@@ -512,7 +512,7 @@ private void checkFlagEntitlement(
512512
PolicyParser.getEntitlementTypeName(entitlementClass)
513513
),
514514
callerClass,
515-
classEntitlements.componentName()
515+
classEntitlements
516516
);
517517
}
518518
classEntitlements.logger()
@@ -556,21 +556,19 @@ public void checkWriteProperty(Class<?> callerClass, String property) {
556556
property
557557
),
558558
callerClass,
559-
entitlements.componentName()
559+
entitlements
560560
);
561561
}
562562

563-
private void notEntitled(String message, Class<?> callerClass, String componentName) {
563+
private void notEntitled(String message, Class<?> callerClass, ModuleEntitlements entitlements) {
564564
var exception = new NotEntitledException(message);
565565
// Don't emit a log for muted classes, e.g. classes containing self tests
566566
if (mutedClasses.contains(callerClass) == false) {
567-
var moduleName = callerClass.getModule().getName();
568-
var notEntitledLogger = getLogger(componentName, moduleName);
569567
String frameInfoSuffix = StackWalker.getInstance(RETAIN_CLASS_REFERENCE)
570568
.walk(this::findRequestingFrame)
571569
.map(frame -> "\n\tat " + frame)
572570
.orElse("");
573-
notEntitledLogger.warn("Not entitled: " + message + frameInfoSuffix);
571+
entitlements.logger().warn("Not entitled: " + message + frameInfoSuffix);
574572
}
575573
throw exception;
576574
}

0 commit comments

Comments
 (0)