Use equals() to compare String-s over operators in hasRemoteClusters() (#115154)

pawankartik-elastic · web-flow · commit 6a73f89d3172 · 2024-10-21T13:38:46.000+01:00
diff --git a/server/src/main/java/org/elasticsearch/action/search/SearchResponse.java b/server/src/main/java/org/elasticsearch/action/search/SearchResponse.java
@@ -787,7 +787,8 @@ public boolean hasClusterObjects() {
          *              This will be false for local-cluster (non-CCS) only searches.
          */
         public boolean hasRemoteClusters() {
-            return total > 1 || clusterInfo.keySet().stream().anyMatch(alias -> alias != RemoteClusterAware.LOCAL_CLUSTER_GROUP_KEY);
+            return total > 1
+                || clusterInfo.keySet().stream().anyMatch(alias -> alias.equals(RemoteClusterAware.LOCAL_CLUSTER_GROUP_KEY) == false);
         }
 
     }

Original file line number	Diff line number	Diff line change
`@@ -787,7 +787,8 @@ public boolean hasClusterObjects() {`
`787`	`787`	`* This will be false for local-cluster (non-CCS) only searches.`
`788`	`788`	`*/`
`789`	`789`	`public boolean hasRemoteClusters() {`
`790`		`- return total > 1 \|\| clusterInfo.keySet().stream().anyMatch(alias -> alias != RemoteClusterAware.LOCAL_CLUSTER_GROUP_KEY);`
	`790`	`+ return total > 1`
	`791`	`+ \|\| clusterInfo.keySet().stream().anyMatch(alias -> alias.equals(RemoteClusterAware.LOCAL_CLUSTER_GROUP_KEY) == false);`
`791`	`792`	`}`
`792`	`793`
`793`	`794`	`}`