fixed length bug

Author: martijnvg

server/src/main/java/org/elasticsearch/index/codec/tsdb/es819/ES819TSDBDocValuesProducer.java

@@ -1253,13 +1253,14 @@ public void loadBlock(BlockLoader.SingletonLongBuilder builder, BlockLoader.Docs
                                         }
                                     } else {
                                         // consume remaining
-                                        int length = ES819TSDBDocValuesFormat.NUMERIC_BLOCK_SIZE - firstBlockInIndex;
-                                        if (docs.count() < length) {
-                                            builder.appendLongs(currentBlock, firstBlockInIndex, docs.count());
+                                        int docsLength = docs.count() - offset;
+                                        int blockLength = ES819TSDBDocValuesFormat.NUMERIC_BLOCK_SIZE - firstBlockInIndex;
+                                        if (docsLength< blockLength) {
+                                            builder.appendLongs(currentBlock, firstBlockInIndex, docsLength);
                                             return;
                                         } else {
-                                            builder.appendLongs(currentBlock, firstBlockInIndex, length);
-                                            start = offset + length;
+                                            builder.appendLongs(currentBlock, firstBlockInIndex, blockLength);
+                                            start = offset + blockLength;
                                         }
                                     }
 
@@ -1358,13 +1359,14 @@ public void loadBlock(BlockLoader.TSSingletonOrdinalsBuilder builder, BlockLoade
                                         }
                                     } else {
                                         // consume remaining
-                                        int length = ES819TSDBDocValuesFormat.NUMERIC_BLOCK_SIZE - firstBlockInIndex;
-                                        if (docs.count() < length) {
-                                            builder.appendOrds(currentBlock, firstBlockInIndex, docs.count());
+                                        int blockLength = ES819TSDBDocValuesFormat.NUMERIC_BLOCK_SIZE - firstBlockInIndex;
+                                        int docsLength = docs.count() - offset;
+                                        if (docsLength < blockLength) {
+                                            builder.appendOrds(currentBlock, firstBlockInIndex, docsLength);
                                             return;
                                         } else {
-                                            builder.appendOrds(currentBlock, firstBlockInIndex, length);
-                                            start = offset + length;
+                                            builder.appendOrds(currentBlock, firstBlockInIndex, blockLength);
+                                            start = offset + blockLength;
                                         }
                                     }
 

x-pack/plugin/esql/compute/src/main/java/org/elasticsearch/compute/lucene/read/TSSingletonOrdinalsBuilder.java

@@ -61,7 +61,11 @@ public TSSingletonOrdinalsBuilder appendOrd(long ord) {
 
     @Override
     public BlockLoader.TSSingletonOrdinalsBuilder appendOrds(long[] values, int from, int length) {
-        System.arraycopy(values, from, ords, count, length);
+        try {
+            System.arraycopy(values, from, ords, count, length);
+        } catch (ArrayIndexOutOfBoundsException e) {
+            throw e;
+        }
         count += length;
         return this;
     }