try to get rid of some instanceofs

Author: JonasKunz

x-pack/plugin/esql/compute/gen/src/main/java/org/elasticsearch/compute/gen/AggregatorImplementer.java

@@ -122,7 +122,7 @@ public AggregatorImplementer(
         }).filter(a -> a instanceof PositionArgument == false).toList();
 
         this.tryToUseVectors = aggParams.stream().anyMatch(a -> (a instanceof BlockArgument) == false)
-            && aggParams.stream().noneMatch(a -> a instanceof StandardArgument && a.hasVector() == false);
+            && aggParams.stream().noneMatch(a -> a.supportsVectorReadAccess() == false);
 
         this.createParameters = init.getParameters()
             .stream()

x-pack/plugin/esql/compute/gen/src/main/java/org/elasticsearch/compute/gen/EvaluatorImplementer.java

@@ -18,7 +18,6 @@
 import org.elasticsearch.compute.gen.argument.BlockArgument;
 import org.elasticsearch.compute.gen.argument.BuilderArgument;
 import org.elasticsearch.compute.gen.argument.FixedArgument;
-import org.elasticsearch.compute.gen.argument.PositionArgument;
 
 import java.util.ArrayList;
 import java.util.List;
@@ -71,9 +70,7 @@ public EvaluatorImplementer(
             declarationType.getSimpleName() + extraName + "Evaluator"
         );
         this.processOutputsMultivalued = this.processFunction.hasBlockType;
-        boolean anyParameterNotSupportingVectors = this.processFunction.args.stream()
-            .filter(a -> a instanceof FixedArgument == false && a instanceof PositionArgument == false)
-            .anyMatch(a -> a.hasVector() == false);
+        boolean anyParameterNotSupportingVectors = this.processFunction.args.stream().anyMatch(a -> a.supportsVectorReadAccess() == false);
         vectorsUnsupported = processOutputsMultivalued || anyParameterNotSupportingVectors;
         this.allNullsIsNull = allNullsIsNull;
     }

x-pack/plugin/esql/compute/gen/src/main/java/org/elasticsearch/compute/gen/GroupingAggregatorImplementer.java

@@ -128,7 +128,7 @@ public GroupingAggregatorImplementer(
         }).filter(a -> a instanceof PositionArgument == false).toList();
 
         this.hasOnlyBlockArguments = this.aggParams.stream().allMatch(a -> a instanceof BlockArgument);
-        this.allArgumentsSupportVectors = aggParams.stream().noneMatch(a -> a instanceof StandardArgument && a.hasVector() == false);
+        this.allArgumentsSupportVectors = aggParams.stream().noneMatch(a -> a.supportsVectorReadAccess() == false);
 
         this.createParameters = init.getParameters()
             .stream()

x-pack/plugin/esql/compute/gen/src/main/java/org/elasticsearch/compute/gen/argument/Argument.java

@@ -117,8 +117,11 @@ default TypeName elementType() {
      */
     TypeName dataType(boolean blockStyle);
 
-    default boolean hasVector() {
-        return dataType(false) != null;
+    /**
+     * False if and only if there is a block backing this parameter and that block does not support access as a vector. Otherwise true.
+     */
+    default boolean supportsVectorReadAccess() {
+        return true;
     }
 
     /**

x-pack/plugin/esql/compute/gen/src/main/java/org/elasticsearch/compute/gen/argument/ArrayArgument.java

@@ -35,6 +35,11 @@ public TypeName dataType(boolean blockStyle) {
         return ArrayTypeName.of(vectorType(type));
     }
 
+    @Override
+    public boolean supportsVectorReadAccess() {
+        return vectorType(type) != null;
+    }
+
     @Override
     public String paramName(boolean blockStyle) {
         return name + (blockStyle ? "Block" : "Vector") + "s";

x-pack/plugin/esql/compute/gen/src/main/java/org/elasticsearch/compute/gen/argument/StandardArgument.java

@@ -35,6 +35,11 @@ public TypeName dataType(boolean blockStyle) {
         return vectorType(type);
     }
 
+    @Override
+    public boolean supportsVectorReadAccess() {
+        return dataType(false) != null;
+    }
+
     @Override
     public String paramName(boolean blockStyle) {
         return name + (blockStyle ? "Block" : "Vector");