Rename method

Author: nielsbauman

x-pack/plugin/ilm/src/main/java/org/elasticsearch/xpack/ilm/IndexLifecycleService.java

@@ -590,7 +590,7 @@ PolicyStepsRegistry getPolicyRegistry() {
         return policyRegistry;
     }
 
-    static boolean indicesOnShuttingDownNodesInDangerousStep(ClusterState state, String nodeId) {
+    static boolean hasIndicesInDangerousStepForNodeShutdown(ClusterState state, String nodeId) {
         final Set<String> shutdownNodes = PluginShutdownService.shutdownTypeNodes(
             state,
             SingleNodeShutdownMetadata.Type.REMOVE,
@@ -649,7 +649,7 @@ public boolean safeToShutdown(String nodeId, SingleNodeShutdownMetadata.Type shu
             case REPLACE:
             case REMOVE:
             case SIGTERM:
-                return indicesOnShuttingDownNodesInDangerousStep(clusterService.state(), nodeId);
+                return hasIndicesInDangerousStepForNodeShutdown(clusterService.state(), nodeId);
             default:
                 throw new IllegalArgumentException("unknown shutdown type: " + shutdownType);
         }

x-pack/plugin/ilm/src/test/java/org/elasticsearch/xpack/ilm/IndexLifecycleServiceTests.java

@@ -524,16 +524,16 @@ public void testParsingOriginationDateBeforeIndexCreation() {
         }
     }
 
-    public void testIndicesOnShuttingDownNodesInDangerousStep() {
+    public void testHasIndicesInDangerousStepForNodeShutdown() {
         for (SingleNodeShutdownMetadata.Type type : List.of(
             SingleNodeShutdownMetadata.Type.REMOVE,
             SingleNodeShutdownMetadata.Type.SIGTERM,
             SingleNodeShutdownMetadata.Type.REPLACE
         )) {
             final var project = ProjectMetadata.builder(randomProjectIdOrDefault()).build();
             ClusterState state = ClusterState.builder(ClusterName.DEFAULT).putProjectMetadata(project).build();
-            assertThat(IndexLifecycleService.indicesOnShuttingDownNodesInDangerousStep(state, "regular_node"), equalTo(true));
-            assertThat(IndexLifecycleService.indicesOnShuttingDownNodesInDangerousStep(state, "shutdown_node"), equalTo(true));
+            assertThat(IndexLifecycleService.hasIndicesInDangerousStepForNodeShutdown(state, "regular_node"), equalTo(true));
+            assertThat(IndexLifecycleService.hasIndicesInDangerousStepForNodeShutdown(state, "shutdown_node"), equalTo(true));
 
             IndexMetadata nonDangerousIndex = IndexMetadata.builder("no_danger")
                 .settings(settings(IndexVersion.current()).put(LifecycleSettings.LIFECYCLE_NAME, "mypolicy"))
@@ -603,8 +603,8 @@ public void testIndicesOnShuttingDownNodesInDangerousStep() {
                 .build();
 
             // No danger yet, because no node is shutting down
-            assertThat(IndexLifecycleService.indicesOnShuttingDownNodesInDangerousStep(state, "regular_node"), equalTo(true));
-            assertThat(IndexLifecycleService.indicesOnShuttingDownNodesInDangerousStep(state, "shutdown_node"), equalTo(true));
+            assertThat(IndexLifecycleService.hasIndicesInDangerousStepForNodeShutdown(state, "regular_node"), equalTo(true));
+            assertThat(IndexLifecycleService.hasIndicesInDangerousStepForNodeShutdown(state, "shutdown_node"), equalTo(true));
 
             state = ClusterState.builder(state)
                 .metadata(
@@ -628,11 +628,11 @@ public void testIndicesOnShuttingDownNodesInDangerousStep() {
                 )
                 .build();
 
-            assertThat(IndexLifecycleService.indicesOnShuttingDownNodesInDangerousStep(state, "regular_node"), equalTo(true));
+            assertThat(IndexLifecycleService.hasIndicesInDangerousStepForNodeShutdown(state, "regular_node"), equalTo(true));
             // No danger, because this is a "RESTART" type shutdown
             assertThat(
                 "restart type shutdowns are not considered dangerous",
-                IndexLifecycleService.indicesOnShuttingDownNodesInDangerousStep(state, "shutdown_node"),
+                IndexLifecycleService.hasIndicesInDangerousStepForNodeShutdown(state, "shutdown_node"),
                 equalTo(true)
             );
 
@@ -663,7 +663,7 @@ public void testIndicesOnShuttingDownNodesInDangerousStep() {
                 .build();
 
             // The dangerous index should be calculated as being in danger now
-            assertThat(IndexLifecycleService.indicesOnShuttingDownNodesInDangerousStep(state, "shutdown_node"), equalTo(false));
+            assertThat(IndexLifecycleService.hasIndicesInDangerousStepForNodeShutdown(state, "shutdown_node"), equalTo(false));
         }
     }
 }