Skip to content

Commit 6d43d16

Browse files
committed
[ES|QL] Change rounding mode in tests to HALF_DOWN
The current rounding mode in some of the tests in ESQL uses DOWN which truncates more than rounds and can result in some tests failing with errors like `row 0 column 0:0: expected <0.05235999> but was <0.05236>` HALF_DOWN would round this up
1 parent 59a10bd commit 6d43d16

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

x-pack/plugin/esql/qa/server/src/main/java/org/elasticsearch/xpack/esql/qa/rest/EsqlSpecTestCase.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -371,9 +371,9 @@ private Object valueMapper(CsvTestUtils.Type type, Object value) {
371371
}
372372
return values;
373373
} else if (value instanceof Double d) {
374-
return new BigDecimal(d).round(new MathContext(7, RoundingMode.DOWN)).doubleValue();
374+
return new BigDecimal(d).round(new MathContext(7, RoundingMode.HALF_DOWN)).doubleValue();
375375
} else if (value instanceof String s) {
376-
return new BigDecimal(s).round(new MathContext(7, RoundingMode.DOWN)).doubleValue();
376+
return new BigDecimal(s).round(new MathContext(7, RoundingMode.HALF_DOWN)).doubleValue();
377377
}
378378
}
379379
if (type == CsvTestUtils.Type.TEXT || type == CsvTestUtils.Type.KEYWORD || type == CsvTestUtils.Type.SEMANTIC_TEXT) {

0 commit comments

Comments
 (0)