Add separate setting for logging interval, reduce default to 5 minutes.

Author: nicktindall

server/src/main/java/org/elasticsearch/cluster/routing/allocation/allocator/UndesiredAllocationsTracker.java

@@ -41,6 +41,17 @@ public class UndesiredAllocationsTracker {
         Setting.Property.NodeScope
     );
 
+    /**
+     * The minimum amount of time between warnings about persistent undesired allocations
+     */
+    public static final Setting<TimeValue> UNDESIRED_ALLOCATION_DURATION_LOG_INTERVAL_SETTING = Setting.timeSetting(
+        "cluster.routing.allocation.desired_balance.undesired_duration_logging.interval",
+        TimeValue.timeValueMinutes(5),
+        TimeValue.timeValueMinutes(1),
+        Setting.Property.Dynamic,
+        Setting.Property.NodeScope
+    );
+
     /**
      * The max number of undesired allocations to track. We expect this to be relatively small.
      */
@@ -63,7 +74,7 @@ public class UndesiredAllocationsTracker {
         this.timeProvider = timeProvider;
         this.undesiredAllocationDurationLogInterval = new FrequencyCappedAction(timeProvider::relativeTimeInMillis, TimeValue.ZERO);
         clusterSettings.initializeAndWatch(
-            DesiredBalanceReconciler.UNDESIRED_ALLOCATIONS_LOG_INTERVAL_SETTING,
+            UNDESIRED_ALLOCATION_DURATION_LOG_INTERVAL_SETTING,
             undesiredAllocationDurationLogInterval::setMinInterval
         );
         clusterSettings.initializeAndWatch(

server/src/main/java/org/elasticsearch/common/settings/ClusterSettings.java

@@ -238,6 +238,7 @@ public void apply(Settings value, Settings current, Settings previous) {
         DesiredBalanceReconciler.UNDESIRED_ALLOCATIONS_LOG_INTERVAL_SETTING,
         DesiredBalanceReconciler.UNDESIRED_ALLOCATIONS_LOG_THRESHOLD_SETTING,
         UndesiredAllocationsTracker.UNDESIRED_ALLOCATION_DURATION_LOG_THRESHOLD_SETTING,
+        UndesiredAllocationsTracker.UNDESIRED_ALLOCATION_DURATION_LOG_INTERVAL_SETTING,
         UndesiredAllocationsTracker.MAX_UNDESIRED_ALLOCATIONS_TO_TRACK,
         BreakerSettings.CIRCUIT_BREAKER_LIMIT_SETTING,
         BreakerSettings.CIRCUIT_BREAKER_OVERHEAD_SETTING,