update comment about mystery includes to be more accurate

Author: richard-dennehy

plugins/microsoft-graph-authz/build.gradle

@@ -76,6 +76,7 @@ dependencies {
 
   testRuntimeOnly "net.minidev:json-smart:2.5.2"
   testRuntimeOnly "com.nimbusds:oauth2-oidc-sdk:11.22.2"
+  testRuntimeOnly "com.nimbusds:content-type:2.3"
 
   attributesSchema {
     attribute(patched)

plugins/microsoft-graph-authz/src/main/java/module-info.java

@@ -20,6 +20,9 @@
     requires com.microsoft.graph;
     requires com.azure.identity;
     requires com.microsoft.graph.core;
+    // FIXME both of these module includes are load bearing, because this project is cursed
+    //  we don't need either of these in the plugin, but without the Kotlin include, the plugin fails to compile; without the gson include,
+    //  we get a NoClassDefFoundError at runtime
     requires kotlin.stdlib;
     requires com.google.gson;
 

plugins/microsoft-graph-authz/src/main/java/org/elasticsearch/xpack/security/authz/microsoft/MicrosoftGraphAuthzRealm.java

@@ -64,9 +64,6 @@ public MicrosoftGraphAuthzRealm(UserRoleMapper roleMapper, RealmConfig config) {
             );
         }
 
-        // FIXME both of these lines are load bearing, because this project is cursed
-        new com.google.gson.JsonParser();
-        kotlin.jvm.internal.Intrinsics.checkParameterIsNotNull(clientSecret, "clientSecret");
         // TODO license check
     }