Skip to content

Commit 70d3a1f

Browse files
committed
Un-ignores INLINESTATS tests that should be working
Spoiler: they are not 😢
1 parent 502bbc3 commit 70d3a1f

File tree

1 file changed

+4
-13
lines changed

1 file changed

+4
-13
lines changed

x-pack/plugin/esql/qa/testFixtures/src/main/resources/inlinestats.csv-spec

Lines changed: 4 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -3154,7 +3154,6 @@ count:long | message:keyword
31543154

31553155
multiIndexInlinestatsOfMultiTypedField
31563156
required_capability: inlinestats_v11
3157-
// https://github.com/elastic/elasticsearch/issues/133973
31583157
FROM apps, apps_short
31593158
| INLINESTATS s = sum(id::integer)
31603159
| SORT name, version
@@ -3396,10 +3395,8 @@ warningRegex:java.lang.IllegalArgumentException: milliSeconds \[-1457696696640\]
33963395
2023-10-23T13:53:55.832Z |2023-10-23T13:53:55.832987654Z|1698069235832987654|19
33973396
;
33983397

3399-
ImplicitCastingMultiTypedDateTruncInlinestats_By-Ignore
3398+
ImplicitCastingMultiTypedDateTruncInlinestats_By
34003399
required_capability: inlinestats_v11
3401-
// https://github.com/elastic/elasticsearch/issues/133973
3402-
// optimized incorrectly due to missing references [$$emp_no$converted_to$long{f$}#
34033400

34043401
FROM employees, employees_incompatible
34053402
| KEEP emp_no, hire_date
@@ -3416,10 +3413,8 @@ c:long | yr:date_nanos
34163413
8 | 1994-01-01T00:00:00.000Z
34173414
;
34183415

3419-
ImplicitCastingMultiTypedDateTruncInlinestats_ByWithFilter-Ignore
3416+
ImplicitCastingMultiTypedDateTruncInlinestats_ByWithFilter
34203417
required_capability: inlinestats_v11
3421-
// https://github.com/elastic/elasticsearch/issues/133973
3422-
// optimized incorrectly due to missing references [$$emp_no$converted_to$long{f$}#
34233418

34243419
FROM employees, employees_incompatible
34253420
| KEEP emp_no, hire_date
@@ -3436,10 +3431,8 @@ c:long | yr:date_nanos
34363431
0 | 1994-01-01T00:00:00.000Z
34373432
;
34383433

3439-
ImplicitCastingMultiTypedDateTruncInlinestats_ByWithEval-Ignore
3434+
ImplicitCastingMultiTypedDateTruncInlinestats_ByWithEval
34403435
required_capability: inlinestats_v11
3441-
// https://github.com/elastic/elasticsearch/issues/133973
3442-
// optimized incorrectly due to missing references [$$emp_no$converted_to$long{f$}#
34433436

34443437
FROM employees, employees_incompatible
34453438
| KEEP emp_no, hire_date
@@ -3457,10 +3450,8 @@ c:long | yr:date_nanos
34573450
8 | 1994-01-01T00:00:00.000Z
34583451
;
34593452

3460-
ImplicitCastingMultiTypedDateTruncInlinestats_ByWithEvalWithFilter-Ignore
3453+
ImplicitCastingMultiTypedDateTruncInlinestats_ByWithEvalWithFilter
34613454
required_capability: inlinestats_v11
3462-
// https://github.com/elastic/elasticsearch/issues/133973
3463-
// optimized incorrectly due to missing references [$$emp_no$converted_to$long{f$}#
34643455

34653456
FROM employees, employees_incompatible
34663457
| KEEP emp_no, hire_date

0 commit comments

Comments
 (0)