cleanup

Author: mhl-b

server/src/test/java/org/elasticsearch/cluster/routing/allocation/decider/AllocationDecidersTests.java

@@ -44,7 +44,7 @@
 public class AllocationDecidersTests extends ESAllocationTestCase {
 
     public void testCheckAllDecidersBeforeReturningYes() {
-        var allDecisions = generateDecisions(() -> randomFrom(Decision.YES));
+        var allDecisions = generateDecisions(() -> Decision.YES);
         var debugMode = randomFrom(RoutingAllocation.DebugMode.values());
         var expectedDecision = switch (debugMode) {
             case OFF -> Decision.YES;
@@ -57,7 +57,7 @@ public void testCheckAllDecidersBeforeReturningYes() {
 
     public void testCheckAllDecidersBeforeReturningYesNotPreferred() {
         var debugMode = randomFrom(RoutingAllocation.DebugMode.values());
-        var allDecisions = generateDecisions(Decision.YES_NOT_PREFERRED, () -> randomFrom(Decision.YES));
+        var allDecisions = generateDecisions(Decision.YES_NOT_PREFERRED, () -> Decision.YES);
         var expectedDecision = switch (debugMode) {
             case OFF -> Decision.YES_NOT_PREFERRED;
             case EXCLUDE_YES_DECISIONS -> collectToMultiDecision(allDecisions, decision -> decision.preferred() != Decision.Preferred.YES);
@@ -67,7 +67,7 @@ public void testCheckAllDecidersBeforeReturningYesNotPreferred() {
     }
 
     public void testCheckAllDecidersBeforeReturningThrottle() {
-        var allDecisions = generateDecisions(Decision.THROTTLE, () -> randomFrom(Decision.YES));
+        var allDecisions = generateDecisions(Decision.THROTTLE, () -> Decision.YES);
         var debugMode = randomFrom(RoutingAllocation.DebugMode.values());
         var expectedDecision = switch (debugMode) {
             case OFF -> Decision.THROTTLE;