Skip to content

Commit 72f68c1

Browse files
committed
fix docs, add test
1 parent 935bf0a commit 72f68c1

File tree

2 files changed

+11
-3
lines changed

2 files changed

+11
-3
lines changed

docs/changelog/129013.yaml

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,7 @@ highlight:
77
title: Add remote index support to LOOKUP JOIN
88
body: |-
99
Queries containing LOOKUP JOIN now can be preformed on cross-cluster indices, for example:
10-
```
10+
[source,yaml]
11+
----------------------------
1112
FROM logs-*, remote:logs-* | LOOKUP JOIN clients on ip | SORT timestamp | LIMIT 100
12-
```
13+
----------------------------

x-pack/plugin/esql/qa/server/multi-clusters/src/javaRestTest/java/org/elasticsearch/xpack/esql/ccq/MultiClustersIT.java

Lines changed: 8 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -505,7 +505,14 @@ public void testLookupJoinAliasesSkipOld() throws IOException {
505505
mapMatcher = mapMatcher.entry("_clusters", any(Map.class));
506506
mapMatcher = mapMatcher.entry("is_partial", true);
507507
assertMap(result, mapMatcher.entry("columns", columns).entry("values", values));
508-
// TODO: check that the remote is skipped
508+
// check that the remote is skipped
509+
@SuppressWarnings("unchecked")
510+
Map<String, Object> clusters = (Map<String, Object>) result.get("_clusters");
511+
@SuppressWarnings("unchecked")
512+
Map<String, Object> details = (Map<String, Object>) clusters.get("details");
513+
@SuppressWarnings("unchecked")
514+
Map<String, Object> remoteCluster = (Map<String, Object>) details.get("remote_cluster");
515+
assertThat(remoteCluster.get("status"), equalTo("skipped"));
509516
} finally {
510517
wipeLookupIndices();
511518
}

0 commit comments

Comments
 (0)