Tightening rate verification (#131114)

Author: pabloem

x-pack/plugin/esql/src/test/java/org/elasticsearch/xpack/esql/expression/function/aggregate/RateTests.java

@@ -95,8 +95,22 @@ private static TestCaseSupplier makeSupplier(TestCaseSupplier.TypedDataSupplier
             if (dataRows.size() < 2) {
                 matcher = Matchers.nullValue();
             } else {
-                // TODO: check the value?
-                matcher = Matchers.allOf(Matchers.greaterThanOrEqualTo(0.0), Matchers.lessThan(Double.POSITIVE_INFINITY));
+                var maxrate = switch (fieldTypedData.type().widenSmallNumeric()) {
+                    case INTEGER, COUNTER_INTEGER -> dataRows.stream().mapToInt(v -> (Integer) v).max().orElse(0);
+                    case LONG, COUNTER_LONG -> dataRows.stream().mapToLong(v -> (Long) v).max().orElse(0L);
+                    case DOUBLE, COUNTER_DOUBLE -> dataRows.stream().mapToDouble(v -> (Double) v).max().orElse(0.0);
+                    default -> throw new IllegalStateException("Unexpected value: " + fieldTypedData.type());
+                };
+                var minrate = switch (fieldTypedData.type().widenSmallNumeric()) {
+                    case INTEGER, COUNTER_INTEGER -> dataRows.stream().mapToInt(v -> (Integer) v).min().orElse(0);
+                    case LONG, COUNTER_LONG -> dataRows.stream().mapToLong(v -> (Long) v).min().orElse(0L);
+                    case DOUBLE, COUNTER_DOUBLE -> dataRows.stream().mapToDouble(v -> (Double) v).min().orElse(0.0);
+                    default -> throw new IllegalStateException("Unexpected value: " + fieldTypedData.type());
+                };
+                // If the minrate is greater than 0, we need to adjust the maxrate accordingly
+                minrate = Math.min(minrate, 0);
+                maxrate = Math.max(maxrate, maxrate - minrate);
+                matcher = Matchers.allOf(Matchers.greaterThanOrEqualTo(minrate), Matchers.lessThanOrEqualTo(maxrate));
             }
             return new TestCaseSupplier.TestCase(
                 List.of(fieldTypedData, timestampsField),