Skip to content

Commit 73980fa

Browse files
committed
include indices from un-merged responses
1 parent 068eaa3 commit 73980fa

File tree

3 files changed

+15
-16
lines changed

3 files changed

+15
-16
lines changed

x-pack/plugin/esql/qa/testFixtures/src/main/java/org/elasticsearch/xpack/esql/EsqlTestUtils.java

Lines changed: 9 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -132,6 +132,7 @@
132132
import java.util.Map;
133133
import java.util.Set;
134134
import java.util.TreeMap;
135+
import java.util.function.Function;
135136
import java.util.jar.JarInputStream;
136137
import java.util.zip.ZipEntry;
137138

@@ -548,23 +549,17 @@ public static List<List<Object>> getValuesList(EsqlQueryResponse results) {
548549
}
549550

550551
public static List<List<Object>> getValuesList(Iterator<Iterator<Object>> values) {
551-
var valuesList = new ArrayList<List<Object>>();
552-
values.forEachRemaining(row -> {
553-
var rowValues = new ArrayList<>();
554-
row.forEachRemaining(rowValues::add);
555-
valuesList.add(rowValues);
556-
});
557-
return valuesList;
552+
return toList(values, row -> toList(row, Function.identity()));
558553
}
559554

560555
public static List<List<Object>> getValuesList(Iterable<Iterable<Object>> values) {
561-
var valuesList = new ArrayList<List<Object>>();
562-
values.iterator().forEachRemaining(row -> {
563-
var rowValues = new ArrayList<>();
564-
row.iterator().forEachRemaining(rowValues::add);
565-
valuesList.add(rowValues);
566-
});
567-
return valuesList;
556+
return toList(values.iterator(), row -> toList(row.iterator(), Function.identity()));
557+
}
558+
559+
private static <E, T> List<T> toList(Iterator<E> iterable, Function<E, T> transformer) {
560+
var list = new ArrayList<T>();
561+
iterable.forEachRemaining(e -> list.add(transformer.apply(e)));
562+
return list;
568563
}
569564

570565
public static List<String> withDefaultLimitWarning(List<String> warnings) {

x-pack/plugin/esql/src/internalClusterTest/java/org/elasticsearch/xpack/esql/action/CrossClusterEnrichIT.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -367,7 +367,8 @@ public void testLimitThenEnrichRemote() {
367367
FROM *:events,events
368368
| LIMIT 25
369369
| eval ip= TO_STR(host)
370-
| %s | KEEP host, timestamp, user, os
370+
| %s
371+
| KEEP host, timestamp, user, os
371372
""", enrichHosts(Enrich.Mode.REMOTE));
372373
try (EsqlQueryResponse resp = runQuery(query, requestIncludeMeta)) {
373374
var values = getValuesList(resp);

x-pack/plugin/esql/src/main/java/org/elasticsearch/xpack/esql/session/IndexResolver.java

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -42,6 +42,7 @@
4242
import java.util.TreeMap;
4343
import java.util.TreeSet;
4444

45+
import static java.util.stream.Collectors.toSet;
4546
import static org.elasticsearch.xpack.esql.core.type.DataType.DATETIME;
4647
import static org.elasticsearch.xpack.esql.core.type.DataType.KEYWORD;
4748
import static org.elasticsearch.xpack.esql.core.type.DataType.OBJECT;
@@ -78,7 +79,9 @@ public void resolveConcreteIndices(String indexPattern, QueryBuilder requestFilt
7879
client.execute(
7980
EsqlResolveFieldsAction.TYPE,
8081
createFieldCapsRequest(indexPattern, Set.of("_id"), requestFilter, false),
81-
listener.delegateFailureAndWrap((l, response) -> l.onResponse(Set.of(response.getIndices())))
82+
listener.delegateFailureAndWrap((l, response) -> {
83+
l.onResponse(response.getIndexResponses().stream().map(FieldCapabilitiesIndexResponse::getIndexName).collect(toSet()));
84+
})
8285
);
8386
}
8487

0 commit comments

Comments
 (0)