BWC changes

Author: szybia

docs/changelog/130325.yaml

@@ -6,7 +6,7 @@ issues: []
 
 breaking:
   title: Return 400 on invalid processor(s) in Simulate API
-  area: Ingest Node
+  area: Ingest
   details: >-
     In earlier versions of {es}, the Simulate API would return a 500 error when encountering invalid processors. Now, it returns a 400 Bad Request error instead.
 

modules/ingest-common/src/yamlRestTest/resources/rest-api-spec/test/ingest/120_grok.yml

@@ -158,6 +158,9 @@ teardown:
 
 ---
 "Test simulate with invalid GROK pattern":
+  - requires:
+      cluster_features: ["simulate.ingest.400_on_failure"]
+      reason: "simulate.ingest returned 500 on failure before"
   - skip:
         features: headers
   - do:

rest-api-spec/src/yamlRestTest/resources/rest-api-spec/test/simulate.ingest/10_basic.yml

@@ -600,7 +600,9 @@ setup:
 
 ---
 "Test bad pipeline substitution":
-
+  - requires:
+      cluster_features: ["simulate.ingest.400_on_failure"]
+      reason: "simulate.ingest returned 500 on failure before"
   - skip:
       features: [headers, allowed_warnings]
 
@@ -764,7 +766,7 @@ setup:
   - skip:
       features: headers
   - do:
-      catch: request
+      catch: bad_request
       headers:
         Content-Type: application/json
       simulate.ingest:
@@ -786,5 +788,5 @@ setup:
               }
             }
           }
-  - match: { status: 500 }
+  - match: { status: 400 }
   - contains: { error.reason: "Provided a pipeline property which is managed by the system: created_date." }

server/src/main/java/org/elasticsearch/ingest/IngestFeatures.java

@@ -16,6 +16,9 @@
 import java.util.Set;
 
 public class IngestFeatures implements FeatureSpecification {
+
+    private static final NodeFeature SIMULATE_INGEST_400_ON_FAILURE = new NodeFeature("simulate.ingest.400_on_failure", true);
+
     @Override
     public Set<NodeFeature> getFeatures() {
         if (DataStream.LOGS_STREAM_FEATURE_FLAG) {
@@ -24,4 +27,9 @@ public Set<NodeFeature> getFeatures() {
             return Set.of();
         }
     }
+
+    @Override
+    public Set<NodeFeature> getTestFeatures() {
+        return Set.of(SIMULATE_INGEST_400_ON_FAILURE);
+    }
 }

server/src/test/java/org/elasticsearch/ingest/SimulateIngestServiceTests.java

@@ -36,7 +36,6 @@
 import static org.hamcrest.Matchers.contains;
 import static org.hamcrest.Matchers.equalTo;
 import static org.hamcrest.Matchers.is;
-import static org.junit.Assert.assertThrows;
 import static org.mockito.ArgumentMatchers.anyString;
 import static org.mockito.Mockito.mock;
 import static org.mockito.Mockito.when;
@@ -136,7 +135,8 @@ public void testRethrowingOfElasticParseExceptionFromProcessors() {
             newHashMap("pipeline1", newHashMap("processors", List.of(Map.of("parse_exception_processor", new HashMap<>(0))))),
             Map.of(),
             Map.of(),
-            Map.of()
+            Map.of(),
+            null
         );
 
         final ElasticsearchParseException ex = assertThrows(