Set correctly number of bits for query and index

Author: carlosdelest

server/src/main/java/org/elasticsearch/index/codec/vectors/OptimizedScalarQuantizer.java

@@ -132,8 +132,6 @@ public QuantizationResult scalarQuantize(float[] vector, byte[] destination, byt
             int assignment = Math.round((xi - a) / step);
             sumQuery += assignment;
             destination[h] = (byte) assignment;
-            assert assignment >= 0 && assignment < points
-                : "assignment: " + assignment + ", a: " + a + ", b: " + b + ", step: " + step + ", xi: " + xi;
         }
         return new QuantizationResult(
             intervalScratch[0],

server/src/main/java/org/elasticsearch/index/codec/vectors/es910/ES910BinaryQuantizedVectorsFormat.java

@@ -101,8 +101,8 @@ public class ES910BinaryQuantizedVectorsFormat extends FlatVectorsFormat {
     private static final DirectIOLucene99FlatVectorsFormat rawVectorFormat = new DirectIOLucene99FlatVectorsFormat(
         FlatVectorScorerUtil.getLucene99FlatVectorsScorer()
     );
-    public static final byte DEFAULT_INDEX_BITS = (byte) 1;
-    public static final byte DEFAULT_QUERY_BITS = (byte) 4;
+    private static byte DEFAULT_INDEX_BITS = (byte) 1;
+    private static byte DEFAULT_QUERY_BITS = (byte) 4;
 
     private final ES910BinaryFlatVectorsScorer scorer;
 
@@ -118,6 +118,10 @@ public ES910BinaryQuantizedVectorsFormat(byte indexBits, byte queryBits) {
         super(NAME);
         this.indexBits = indexBits;
         this.queryBits = queryBits;
+        // Set the default bits for index and query vectors. I know, I know, this is a hack, but we
+        // don't have the possibility of doing a PerFieldMapperCodec yet on KnnSearcher
+        DEFAULT_QUERY_BITS = queryBits;
+        DEFAULT_INDEX_BITS = indexBits;
         this.scorer = new ES910BinaryFlatVectorsScorer(FlatVectorScorerUtil.getLucene99FlatVectorsScorer(), queryBits);
     }