Skip to content

Commit 75fbbe4

Browse files
committed
fix new instances
1 parent c56ec3a commit 75fbbe4

File tree

4 files changed

+9
-9
lines changed

4 files changed

+9
-9
lines changed

server/src/main/java/org/elasticsearch/TransportVersions.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,7 @@ static TransportVersion def(int id) {
4444
if (id < IDS.last()) {
4545
throw new IllegalArgumentException("Version id " + id + " is not defined in the right location. Keep constants sorted");
4646
}
47-
return new TransportVersion(id);
47+
return new TransportVersion(null, id, null);
4848
}
4949

5050
// TODO: ES-10337 we can remove all transport versions earlier than 8.18

server/src/test/java/org/elasticsearch/transport/TransportHandshakerTests.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -258,11 +258,11 @@ public void testHandshakeResponseFromOlderNodeWithPatchedProtocol() throws Excep
258258
private static TransportVersion getRandomIncompatibleTransportVersion() {
259259
return randomBoolean()
260260
// either older than MINIMUM_COMPATIBLE
261-
? new TransportVersion(between(1, TransportVersions.MINIMUM_COMPATIBLE.id() - 1))
261+
? new TransportVersion(null, between(1, TransportVersions.MINIMUM_COMPATIBLE.id() - 1), null)
262262
// or between MINIMUM_COMPATIBLE and current but not known
263263
: randomValueOtherThanMany(
264264
TransportVersion::isKnown,
265-
() -> new TransportVersion(between(TransportVersions.MINIMUM_COMPATIBLE.id(), TransportVersion.current().id()))
265+
() -> new TransportVersion(null, between(TransportVersions.MINIMUM_COMPATIBLE.id(), TransportVersion.current().id()), null)
266266
);
267267
}
268268

test/framework/src/main/java/org/elasticsearch/test/TransportVersionUtils.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -103,7 +103,7 @@ public static TransportVersion getNextVersion(TransportVersion version, boolean
103103
if (higher == null) {
104104
if (createIfNecessary) {
105105
// create a new transport version one greater than specified
106-
return new TransportVersion(version.id() + 1);
106+
return new TransportVersion(null, version.id() + 1, null);
107107
} else {
108108
throw new IllegalArgumentException("couldn't find any released versions after [" + version + "]");
109109
}

x-pack/plugin/inference/src/test/java/org/elasticsearch/xpack/inference/services/cohere/embeddings/CohereEmbeddingTypeTests.java

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -17,21 +17,21 @@
1717
public class CohereEmbeddingTypeTests extends ESTestCase {
1818
public void testTranslateToVersion_ReturnsInt8_WhenVersionIsBeforeByteEnumAddition_WhenSpecifyingByte() {
1919
assertThat(
20-
CohereEmbeddingType.translateToVersion(CohereEmbeddingType.BYTE, new TransportVersion(8_613_00_0)),
20+
CohereEmbeddingType.translateToVersion(CohereEmbeddingType.BYTE, new TransportVersion(null, 8_613_00_0, null)),
2121
is(CohereEmbeddingType.INT8)
2222
);
2323
}
2424

2525
public void testTranslateToVersion_ReturnsInt8_WhenVersionIsBeforeByteEnumAddition_WhenSpecifyingInt8() {
2626
assertThat(
27-
CohereEmbeddingType.translateToVersion(CohereEmbeddingType.INT8, new TransportVersion(8_613_00_0)),
27+
CohereEmbeddingType.translateToVersion(CohereEmbeddingType.INT8, new TransportVersion(null, 8_613_00_0, null)),
2828
is(CohereEmbeddingType.INT8)
2929
);
3030
}
3131

3232
public void testTranslateToVersion_ReturnsFloat_WhenVersionIsBeforeByteEnumAddition_WhenSpecifyingFloat() {
3333
assertThat(
34-
CohereEmbeddingType.translateToVersion(CohereEmbeddingType.FLOAT, new TransportVersion(8_613_00_0)),
34+
CohereEmbeddingType.translateToVersion(CohereEmbeddingType.FLOAT, new TransportVersion(null, 8_613_00_0, null)),
3535
is(CohereEmbeddingType.FLOAT)
3636
);
3737
}
@@ -52,14 +52,14 @@ public void testTranslateToVersion_ReturnsFloat_WhenVersionOnByteEnumAddition_Wh
5252

5353
public void testTranslateToVersion_ReturnsInt8_WhenVersionIsBeforeBitEnumAdditionPatch_WhenSpecifyingBit() {
5454
assertThat(
55-
CohereEmbeddingType.translateToVersion(CohereEmbeddingType.BIT, new TransportVersion(8_840_0_00)),
55+
CohereEmbeddingType.translateToVersion(CohereEmbeddingType.BIT, new TransportVersion(null, 8_840_0_00, null)),
5656
is(CohereEmbeddingType.INT8)
5757
);
5858
}
5959

6060
public void testTranslateToVersion_ReturnsInt8_WhenVersionIsBeforeBitEnumAddition_WhenSpecifyingBit() {
6161
assertThat(
62-
CohereEmbeddingType.translateToVersion(CohereEmbeddingType.BIT, new TransportVersion(9_000_0_00)),
62+
CohereEmbeddingType.translateToVersion(CohereEmbeddingType.BIT, new TransportVersion(null, 9_000_0_00, null)),
6363
is(CohereEmbeddingType.INT8)
6464
);
6565
}

0 commit comments

Comments
 (0)