polish

Author: jan-elastic

x-pack/plugin/core/src/main/java/org/elasticsearch/xpack/core/inference/results/EmbeddingResults.java

@@ -19,7 +19,7 @@
  * A call to the inference service may contain multiple input texts, so this results may
  * contain multiple results.
  */
-public interface EmbeddingResults<C extends EmbeddingResults.Chunk, R extends EmbeddingResults.Embedding<C>>
+public interface EmbeddingResults<C extends EmbeddingResults.Chunk, E extends EmbeddingResults.Embedding<C>>
     extends
         InferenceServiceResults {
 
@@ -47,5 +47,5 @@ interface Embedding<C extends Chunk> {
     /**
      * The resulting list of embeddings for the input texts to the inference service.
      */
-    List<R> embeddings();
+    List<E> embeddings();
 }

x-pack/plugin/core/src/main/java/org/elasticsearch/xpack/core/inference/results/SparseEmbeddingResults.java

@@ -180,7 +180,7 @@ public Chunk toChunk(String text, ChunkedInference.TextOffset offset) {
         }
     }
 
-    public static record Chunk(List<WeightedToken> weightedTokens, String matchedText, ChunkedInference.TextOffset offset)
+    public record Chunk(List<WeightedToken> weightedTokens, String matchedText, ChunkedInference.TextOffset offset)
         implements
             EmbeddingResults.Chunk {
 

x-pack/plugin/core/src/main/java/org/elasticsearch/xpack/core/inference/results/TextEmbeddingBitResults.java

@@ -41,6 +41,7 @@
  *     ]
  * }
  */
+// TODO: let this implement EmbeddingResults, so that this also supports chunking.
 public record TextEmbeddingBitResults(List<TextEmbeddingByteResults.Embedding> embeddings)
     implements
         InferenceServiceResults,