PR feedback

Author: kderusso

docs/reference/query-languages/esql/kibana/definition/functions/match_phrase.json

@@ -118,11 +118,7 @@ public class MatchPhrase extends FullTextFunction implements OptionalArgument, P
     public MatchPhrase(
         Source source,
         @Param(name = "field", type = { "keyword", "text" }, description = "Field that the query will target.") Expression field,
-        @Param(
-            name = "query",
-            type = { "keyword", "text" },
-            description = "Value to find in the provided field."
-        ) Expression matchPhraseQuery,
+        @Param(name = "query", type = { "keyword" }, description = "Value to find in the provided field.") Expression matchPhraseQuery,
         @MapParam(
             name = "options",
             params = {
@@ -200,31 +196,19 @@ public final void writeTo(StreamOutput out) throws IOException {
 
     @Override
     protected TypeResolution resolveParams() {
-        return resolveField().and(resolveQuery()).and(resolveOptions(options(), THIRD)).and(checkParamCompatibility());
+        return resolveField().and(resolveQuery()).and(resolveOptions(options(), THIRD));
     }
 
     private TypeResolution resolveField() {
         return isNotNull(field, sourceText(), FIRST).and(isType(field, FIELD_DATA_TYPES::contains, sourceText(), FIRST, "keyword, text"));
     }
 
     private TypeResolution resolveQuery() {
-        return isType(query(), QUERY_DATA_TYPES::contains, sourceText(), SECOND, "keyword, text").and(
+        return isType(query(), QUERY_DATA_TYPES::contains, sourceText(), SECOND, "keyword").and(
             isNotNullAndFoldable(query(), sourceText(), SECOND)
         );
     }
 
-    private TypeResolution checkParamCompatibility() {
-        DataType fieldType = field().dataType();
-        DataType queryType = query().dataType();
-
-        // Field and query types should match. If the query is a string, then it can match any field type.
-        if ((fieldType == queryType) || (queryType == KEYWORD) || (queryType == TEXT)) {
-            return TypeResolution.TYPE_RESOLVED;
-        }
-
-        return new TypeResolution(formatIncompatibleTypesMessage(fieldType, queryType, sourceText()));
-    }
-
     @Override
     protected Map<String, Object> resolvedOptions() throws InvalidArgumentException {
         return matchPhraseQueryOptions();

x-pack/plugin/esql/src/main/java/org/elasticsearch/xpack/esql/expression/function/fulltext/MatchPhrase.java

@@ -69,16 +69,6 @@ public static void addStringTestCases(List<TestCaseSupplier> suppliers) {
                         (o1, o2) -> true
                     )
                 );
-
-                suppliers.add(
-                    TestCaseSupplier.testCaseSupplier(
-                        queryDataSupplier,
-                        new TestCaseSupplier.TypedDataSupplier(fieldType.typeName(), () -> randomAlphaOfLength(10), DataType.TEXT),
-                        (d1, d2) -> equalTo("string"),
-                        DataType.BOOLEAN,
-                        (o1, o2) -> true
-                    )
-                );
             }
         }
     }