Skip to content

Commit 782dd5f

Browse files
committed
Change wording inm error message function named arguments to named parameters since it has a broader usage.
1 parent 1cab96f commit 782dd5f

File tree

1 file changed

+9
-9
lines changed

1 file changed

+9
-9
lines changed

x-pack/plugin/esql/src/test/java/org/elasticsearch/xpack/esql/parser/StatementParserTests.java

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -2604,11 +2604,11 @@ public void testFailingMetadataWithSquareBrackets() {
26042604
);
26052605
}
26062606

2607-
public void testNamedFunctionArgumentInMap() {
2607+
public void testFunctionNamedParameterInMap() {
26082608
// functions can be scalar, grouping and aggregation
26092609
// functions can be in eval/where/stats/sort/dissect/grok commands, commands in snapshot are not covered
26102610
// positive
2611-
// In eval and where clause as function arguments
2611+
// In eval and where clause as function named parameters
26122612
LinkedHashMap<String, Object> expectedMap1 = new LinkedHashMap<>(4);
26132613
expectedMap1.put("option1", "string");
26142614
expectedMap1.put("option2", 1);
@@ -2652,7 +2652,7 @@ public void testNamedFunctionArgumentInMap() {
26522652
""")
26532653
);
26542654

2655-
// In stats, by and sort as function arguments
2655+
// In stats, by and sort as function named parameters
26562656
assertEquals(
26572657
new OrderBy(
26582658
EMPTY,
@@ -2688,7 +2688,7 @@ by fn2(f3, {"option1":["string1","string2"],"option2":[1,2,3],"option3":2.0,"opt
26882688
""")
26892689
);
26902690

2691-
// In dissect and grok as function arguments
2691+
// In dissect and grok as function named parameter
26922692
LogicalPlan plan = statement("""
26932693
from test
26942694
| dissect fn1(f1, f2, {"option1":"string", "option2":1,"option3":[2.0,3.0,4.0],"option4":[true,false]}) "%{bar}"
@@ -2707,7 +2707,7 @@ by fn2(f3, {"option1":["string1","string2"],"option2":[1,2,3],"option3":2.0,"opt
27072707
assertEquals(ur, relation("test"));
27082708
}
27092709

2710-
public void testNamedFunctionArgumentInMapWithNamedParameters() {
2710+
public void testFunctionNamedParameterInMapWithNamedParameters() {
27112711
// map entry values provided in named parameter, arrays are not supported by named parameters yet
27122712
LinkedHashMap<String, Object> expectedMap1 = new LinkedHashMap<>(4);
27132713
expectedMap1.put("option1", "string");
@@ -2850,7 +2850,7 @@ public void testNamedFunctionArgumentInMapWithNamedParameters() {
28502850
assertEquals(ur, relation("test"));
28512851
}
28522852

2853-
public void testNamedFunctionArgumentWithCaseSensitiveKeys() {
2853+
public void testFunctionNamedParameterWithCaseSensitiveKeys() {
28542854
LinkedHashMap<String, Object> expectedMap1 = new LinkedHashMap<>(3);
28552855
expectedMap1.put("option", "string");
28562856
expectedMap1.put("Option", 1);
@@ -2888,7 +2888,7 @@ public void testNamedFunctionArgumentWithCaseSensitiveKeys() {
28882888
);
28892889
}
28902890

2891-
public void testMultipleNamedFunctionArgumentsNotAllowed() {
2891+
public void testMultipleFunctionNamedParametersNotAllowed() {
28922892
Map<String, String> commands = Map.ofEntries(
28932893
Map.entry("eval x = {}", "41"),
28942894
Map.entry("where {}", "38"),
@@ -2912,7 +2912,7 @@ public void testMultipleNamedFunctionArgumentsNotAllowed() {
29122912
}
29132913
}
29142914

2915-
public void testNamedFunctionArgumentNotInMap() {
2915+
public void testFunctionNamedParameterNotInMap() {
29162916
Map<String, String> commands = Map.ofEntries(
29172917
Map.entry("eval x = {}", "38"),
29182918
Map.entry("where {}", "35"),
@@ -2936,7 +2936,7 @@ public void testNamedFunctionArgumentNotInMap() {
29362936
}
29372937
}
29382938

2939-
public void testNamedFunctionArgumentNotConstant() {
2939+
public void testFunctionNamedParameterNotConstant() {
29402940
Map<String, String[]> commands = Map.ofEntries(
29412941
Map.entry("eval x = {}", new String[] { "31", "35" }),
29422942
Map.entry("where {}", new String[] { "28", "32" }),

0 commit comments

Comments
 (0)