Fix proto response not being flushed to bytebuf

JonasKunz · JonasKunz · commit 79c2d08d9363 · 2025-07-01T15:03:14.000+02:00
diff --git a/x-pack/plugin/metricsdb/src/main/java/org/elasticsearch/xpack/metrics/MetricsDBRestAction.java b/x-pack/plugin/metricsdb/src/main/java/org/elasticsearch/xpack/metrics/MetricsDBRestAction.java
@@ -70,7 +70,9 @@ public RestResponse buildResponse(MetricsDBTransportAction.MetricsResponse r) th
 
     private RestResponse successResponse(MessageLite response) throws IOException {
         var responseBytes = ByteBuffer.allocate(response.getSerializedSize());
-        response.writeTo(CodedOutputStream.newInstance(responseBytes));
+        CodedOutputStream outputStream = CodedOutputStream.newInstance(responseBytes);
+        response.writeTo(outputStream);
+        outputStream.flush();
 
         return new RestResponse(RestStatus.OK, "application/x-protobuf", BytesReference.fromByteBuffer(responseBytes));
     }

Original file line number	Diff line number	Diff line change
`@@ -70,7 +70,9 @@ public RestResponse buildResponse(MetricsDBTransportAction.MetricsResponse r) th`
`70`	`70`
`71`	`71`	`private RestResponse successResponse(MessageLite response) throws IOException {`
`72`	`72`	`var responseBytes = ByteBuffer.allocate(response.getSerializedSize());`
`73`		`- response.writeTo(CodedOutputStream.newInstance(responseBytes));`
	`73`	`+ CodedOutputStream outputStream = CodedOutputStream.newInstance(responseBytes);`
	`74`	`+ response.writeTo(outputStream);`
	`75`	`+ outputStream.flush();`
`74`	`76`
`75`	`77`	`return new RestResponse(RestStatus.OK, "application/x-protobuf", BytesReference.fromByteBuffer(responseBytes));`
`76`	`78`	`}`