Add a (relatively) simple stub test of the parsing

Author: joegallo

modules/ingest-common/src/main/java/org/elasticsearch/ingest/common/CefParser.java

@@ -320,7 +320,8 @@ CefEvent process(String cefString) {
         return event;
     }
 
-    private static List<String> parseHeaders(String cefString) {
+    // visible for testing
+    static List<String> parseHeaders(String cefString) {
         List<String> headers = new ArrayList<>();
         int extensionStart = -1;
         final StringBuilder buffer = new StringBuilder();
@@ -388,7 +389,8 @@ private static void processHeaders(List<String> headers, CefEvent event) {
         }
     }
 
-    private static Map<String, String> parseExtensions(String extensionString) {
+    // visible for testing
+    static Map<String, String> parseExtensions(String extensionString) {
         Map<String, String> extensions = new HashMap<>();
         Matcher matcher = EXTENSION_NEXT_KEY_VALUE_PATTERN.matcher(extensionString);
         int lastEnd = 0;

modules/ingest-common/src/test/java/org/elasticsearch/ingest/common/CefProcessorTests.java

@@ -20,13 +20,41 @@
 import java.util.Map;
 
 import static java.util.Map.entry;
+import static org.hamcrest.Matchers.aMapWithSize;
 import static org.hamcrest.Matchers.containsInAnyOrder;
 import static org.hamcrest.Matchers.equalTo;
 
 public class CefProcessorTests extends ESTestCase {
 
     private IngestDocument document;
 
+    public void testParse() {
+        String message;
+        List<String> headers;
+        Map<String, String> extensions;
+        {
+            message = "CEF:0|vendor|product|version|class|name|severity|";
+            headers = CefParser.parseHeaders(message);
+            extensions = CefParser.parseExtensions(headers.removeLast());
+            assertThat(headers, equalTo(List.of("CEF:0", "vendor", "product", "version", "class", "name", "severity")));
+            assertThat(extensions, aMapWithSize(0));
+        }
+        {
+            message = "CEF:1|vendor|product|version|class|name|severity|someExtension=someValue";
+            headers = CefParser.parseHeaders(message);
+            extensions = CefParser.parseExtensions(headers.removeLast());
+            assertThat(headers, equalTo(List.of("CEF:1", "vendor", "product", "version", "class", "name", "severity")));
+            assertThat(extensions, equalTo(Map.of("someExtension", "someValue")));
+        }
+        {
+            message = "CEF:1|vendor|product\\|pipe|version space|class\\\\slash|name|severity|ext1=some value   ext2=pipe|value  ";
+            headers = CefParser.parseHeaders(message);
+            extensions = CefParser.parseExtensions(headers.removeLast());
+            assertThat(headers, equalTo(List.of("CEF:1", "vendor", "product|pipe", "version space", "class\\slash", "name", "severity")));
+            assertMapsEqual(extensions, Map.ofEntries(entry("ext1", "some value  "), entry("ext2", "pipe|value")));
+        }
+    }
+
     public void testExecute() {
         Map<String, Object> source = new HashMap<>();
         String message = "CEF:0|Elastic|Vaporware|1.0.0-alpha|18|Web request|low|eventId=3457 requestMethod=POST "