Clear per-shard failure earlier in AbstractSearchAsyncAction.onShardResult (#126933)

We can clean the failure before we potentially go async for a partial merge here to save
some heap and needless reference chains to the per-shard result.

Author: original-brownbear

server/src/main/java/org/elasticsearch/action/search/AbstractSearchAsyncAction.java

@@ -500,18 +500,18 @@ protected void onShardResult(Result result) {
         if (logger.isTraceEnabled()) {
             logger.trace("got first-phase result from {}", result != null ? result.getSearchShardTarget() : null);
         }
-        results.consumeResult(result, () -> onShardResultConsumed(result));
-    }
-
-    private void onShardResultConsumed(Result result) {
-        successfulOps.incrementAndGet();
         // clean a previous error on this shard group (note, this code will be serialized on the same shardIndex value level
         // so its ok concurrency wise to miss potentially the shard failures being created because of another failure
         // in the #addShardFailure, because by definition, it will happen on *another* shardIndex
         AtomicArray<ShardSearchFailure> shardFailures = this.shardFailures.get();
         if (shardFailures != null) {
             shardFailures.set(result.getShardIndex(), null);
         }
+        results.consumeResult(result, this::onShardResultConsumed);
+    }
+
+    private void onShardResultConsumed() {
+        successfulOps.incrementAndGet();
         // we need to increment successful ops first before we compare the exit condition otherwise if we
         // are fast we could concurrently update totalOps but then preempt one of the threads which can
         // cause the successor to read a wrong value from successfulOps if second phase is very fast ie. count etc.