Implementing copy_sign function for ESQL

Author: pabloem

x-pack/plugin/esql/compute/gen/src/main/java/org/elasticsearch/compute/gen/Methods.java

@@ -38,6 +38,9 @@
 import static org.elasticsearch.compute.gen.Types.DOUBLE_VECTOR;
 import static org.elasticsearch.compute.gen.Types.DOUBLE_VECTOR_BUILDER;
 import static org.elasticsearch.compute.gen.Types.DOUBLE_VECTOR_FIXED_BUILDER;
+import static org.elasticsearch.compute.gen.Types.FLOAT_BLOCK_BUILDER;
+import static org.elasticsearch.compute.gen.Types.FLOAT_VECTOR_BUILDER;
+import static org.elasticsearch.compute.gen.Types.FLOAT_VECTOR_FIXED_BUILDER;
 import static org.elasticsearch.compute.gen.Types.INT_BLOCK;
 import static org.elasticsearch.compute.gen.Types.INT_BLOCK_BUILDER;
 import static org.elasticsearch.compute.gen.Types.INT_VECTOR;
@@ -216,6 +219,9 @@ static String appendMethod(TypeName t) {
         if (t.equals(TypeName.DOUBLE) || t.equals(DOUBLE_BLOCK) || t.equals(DOUBLE_VECTOR)) {
             return "appendDouble";
         }
+        if (t.equals(TypeName.FLOAT) || t.equals(FLOAT_BLOCK_BUILDER)) {
+            return "appendFloat";
+        }
         throw new IllegalArgumentException("unknown append method for [" + t + "]");
     }
 
@@ -266,6 +272,15 @@ static String buildFromFactory(TypeName t) {
         if (t.equals(DOUBLE_VECTOR_FIXED_BUILDER)) {
             return "newDoubleVectorFixedBuilder";
         }
+        if (t.equals(FLOAT_BLOCK_BUILDER)) {
+            return "newFloatBlockBuilder";
+        }
+        if (t.equals(FLOAT_VECTOR_BUILDER)) {
+            return "newFloatVectorBuilder";
+        }
+        if (t.equals(FLOAT_VECTOR_FIXED_BUILDER)) {
+            return "newFloatVectorFixedBuilder";
+        }
         throw new IllegalArgumentException("unknown build method for [" + t + "]");
     }
 
@@ -289,6 +304,9 @@ static String getMethod(TypeName elementType) {
         if (elementType.equals(TypeName.DOUBLE)) {
             return "getDouble";
         }
+        if (elementType.equals(TypeName.FLOAT)) {
+            return "getFloat";
+        }
         throw new IllegalArgumentException("unknown get method for [" + elementType + "]");
     }
 

x-pack/plugin/esql/compute/gen/src/main/java/org/elasticsearch/compute/gen/Types.java

@@ -252,6 +252,9 @@ static TypeName elementType(TypeName t) {
         if (t.equals(DOUBLE_BLOCK) || t.equals(DOUBLE_VECTOR) || t.equals(DOUBLE_BLOCK_BUILDER)) {
             return TypeName.DOUBLE;
         }
+        if (t.equals(FLOAT_BLOCK) || t.equals(FLOAT_VECTOR) || t.equals(FLOAT_BLOCK_BUILDER)) {
+            return TypeName.FLOAT;
+        }
         throw new IllegalArgumentException("unknown element type for [" + t + "]");
     }
 

x-pack/plugin/esql/qa/testFixtures/src/main/resources/math.csv-spec

@@ -1702,3 +1702,13 @@ emp_no:integer | l1:double | l2:double
 10002          | -7.23     | null     
 10003          | 4.0       | null     
 ;
+
+copySignWithMixedNumericValues
+ROW a = 1.0, b = -2.0
+| EVAL c = COPY_SIGN(a, b)
+| EVAL d = COPY_SIGN(b, a)
+;
+
+a:double | b:double | c:double | d:double
+1.0      | -2.0     | -1.0     | 2.0
+;

x-pack/plugin/esql/src/main/generated/org/elasticsearch/xpack/esql/expression/function/scalar/math/CopySignDoubleEvaluator.java

@@ -89,6 +89,7 @@
 import org.elasticsearch.xpack.esql.expression.function.scalar.math.Atan2;
 import org.elasticsearch.xpack.esql.expression.function.scalar.math.Cbrt;
 import org.elasticsearch.xpack.esql.expression.function.scalar.math.Ceil;
+import org.elasticsearch.xpack.esql.expression.function.scalar.math.CopySign;
 import org.elasticsearch.xpack.esql.expression.function.scalar.math.Cos;
 import org.elasticsearch.xpack.esql.expression.function.scalar.math.Cosh;
 import org.elasticsearch.xpack.esql.expression.function.scalar.math.E;
@@ -318,6 +319,7 @@ private static FunctionDefinition[][] functions() {
                 def(Exp.class, Exp::new, "exp"),
                 def(Floor.class, Floor::new, "floor"),
                 def(Greatest.class, Greatest::new, "greatest"),
+                def(CopySign.class, CopySign::new, "copy_sign"),
                 def(Hypot.class, Hypot::new, "hypot"),
                 def(Log.class, Log::new, "log"),
                 def(Log10.class, Log10::new, "log10"),