Address no commits

Author: julian-elastic

x-pack/plugin/esql/src/main/java/org/elasticsearch/xpack/esql/parser/AstBuilder.java

@@ -7,10 +7,8 @@
 
 package org.elasticsearch.xpack.esql.parser;
 
-import org.elasticsearch.xpack.esql.session.Configuration;
-
 public class AstBuilder extends LogicalPlanBuilder {
-    public AstBuilder(ParsingContext context, Configuration configuration) {
-        super(context, configuration);
+    public AstBuilder(ParsingContext context) {
+        super(context);
     }
 }

x-pack/plugin/esql/src/main/java/org/elasticsearch/xpack/esql/parser/EsqlParser.java

@@ -153,7 +153,7 @@ private <T> T invokeParser(
                 log.trace("Parse tree: {}", tree.toStringTree());
             }
 
-            return result.apply(new AstBuilder(new ExpressionBuilder.ParsingContext(params, metrics), configuration), tree);
+            return result.apply(new AstBuilder(new ExpressionBuilder.ParsingContext(params, metrics)), tree);
         } catch (StackOverflowError e) {
             throw new ParsingException("ESQL statement is too large, causing stack overflow when generating the parsing tree: [{}]", query);
             // likely thrown by an invalid popMode (such as extra closing parenthesis)

x-pack/plugin/esql/src/main/java/org/elasticsearch/xpack/esql/parser/ExpressionBuilder.java

@@ -121,13 +121,10 @@ public abstract class ExpressionBuilder extends IdentifierBuilder {
     public static final int MAX_EXPRESSION_DEPTH = 400;
 
     protected final ParsingContext context;
-    private final Configuration configuration; // NOCOMMIT remove me?
-
     public record ParsingContext(QueryParams params, PlanTelemetry telemetry) {}
 
-    ExpressionBuilder(ParsingContext context, Configuration configuration) {
+    ExpressionBuilder(ParsingContext context) {
         this.context = context;
-        this.configuration = configuration;
     }
 
     protected Expression expression(ParseTree ctx) {

x-pack/plugin/esql/src/main/java/org/elasticsearch/xpack/esql/parser/LogicalPlanBuilder.java

@@ -76,7 +76,6 @@
 import org.elasticsearch.xpack.esql.plan.logical.join.LookupJoin;
 import org.elasticsearch.xpack.esql.plan.logical.show.ShowInfo;
 import org.elasticsearch.xpack.esql.plugin.EsqlPlugin;
-import org.elasticsearch.xpack.esql.session.Configuration;
 import org.joni.exception.SyntaxException;
 
 import java.util.ArrayList;
@@ -91,7 +90,6 @@
 import java.util.function.Function;
 
 import static java.util.Collections.emptyList;
-import static org.elasticsearch.xpack.esql.common.Failure.fail;
 import static org.elasticsearch.xpack.esql.core.type.DataType.KEYWORD;
 import static org.elasticsearch.xpack.esql.core.util.StringUtils.WILDCARD;
 import static org.elasticsearch.xpack.esql.expression.NamedExpressions.mergeOutputExpressions;
@@ -113,8 +111,8 @@ interface PlanFactory extends Function<LogicalPlan, LogicalPlan> {}
      */
     public static final int MAX_QUERY_DEPTH = 500;
 
-    public LogicalPlanBuilder(ParsingContext context, Configuration configuration) {
-        super(context, configuration);
+    public LogicalPlanBuilder(ParsingContext context) {
+        super(context);
     }
 
     private int queryDepth = 0;

x-pack/plugin/esql/src/main/java/org/elasticsearch/xpack/esql/session/Configuration.java

@@ -120,7 +120,6 @@ public Configuration(BlockStreamInput in) throws IOException {
             this.allowPartialResults = false;
         }
         if (in.getTransportVersion().onOrAfter(TransportVersions.ESQL_FIXED_INDEX_LIKE)) {
-            // NOCOMMIT can we look this up without putting it in Configuration?
             this.stringLikeOnIndex = in.readBoolean();
         } else {
             this.stringLikeOnIndex = false;

x-pack/plugin/esql/src/test/java/org/elasticsearch/xpack/esql/planner/FilterTests.java

@@ -51,6 +51,7 @@
 import java.util.Set;
 
 import static java.util.Arrays.asList;
+import static org.elasticsearch.TransportVersions.V_8_17_0;
 import static org.elasticsearch.index.query.QueryBuilders.rangeQuery;
 import static org.elasticsearch.xpack.esql.ConfigurationTestUtils.randomConfiguration;
 import static org.elasticsearch.xpack.esql.EsqlTestUtils.TEST_VERIFIER;
@@ -325,8 +326,8 @@ public void testLikeList() {
             |WHERE {} LIKE ("a+", "b+")
             """, LAST_NAME);
         var plan = plan(query, null);
-
-        var filter = filterQueryForTransportNodes(TransportVersion.current(), plan);
+        // test with an older version, so like list is not supported
+        var filter = filterQueryForTransportNodes(V_8_17_0, plan);
         assertNull(filter);
     }
 
@@ -399,8 +400,7 @@ private QueryBuilder restFilterQuery(String field) {
     }
 
     private QueryBuilder filterQueryForTransportNodes(TransportVersion minTransportVersion, PhysicalPlan plan) {
-        // NOCOMMIT check if null is ok
-        return PlannerUtils.detectFilter(null, minTransportVersion, plan, Set.of(EMP_NO, LAST_NAME)::contains);
+        return PlannerUtils.detectFilter(EsqlTestUtils.TEST_CFG, minTransportVersion, plan, Set.of(EMP_NO, LAST_NAME)::contains);
     }
 
     @Override