Skip to content

Commit 7dfd891

Browse files
committed
addressed PR comments
1 parent c51dd3f commit 7dfd891

File tree

2 files changed

+1
-8
lines changed

2 files changed

+1
-8
lines changed

x-pack/plugin/core/src/main/java/org/elasticsearch/xpack/core/security/authz/store/KibanaOwnedReservedRoleDescriptors.java

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -536,7 +536,6 @@ static RoleDescriptor kibanaSystem(String name) {
536536
// Require "delete_index" to perform ILM policy actions
537537
TransportDeleteIndexAction.TYPE.name(),
538538
TransportIndicesAliasesAction.NAME,
539-
TransportUpdateSettingsAction.TYPE.name(),
540539
TransportAutoPutMappingAction.TYPE.name()
541540
)
542541
.build(),

x-pack/plugin/core/src/test/java/org/elasticsearch/xpack/core/security/authz/store/ReservedRolesStoreTests.java

Lines changed: 1 addition & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1902,7 +1902,7 @@ public void testKibanaSystemRole() {
19021902
assertThat(kibanaRole.indices().allowedIndicesMatcher(TransportIndexAction.NAME).test(indexAbstraction), is(true));
19031903
assertThat(kibanaRole.indices().allowedIndicesMatcher(TransportDeleteAction.NAME).test(indexAbstraction), is(true));
19041904
// The "update" action is also implicitly part of "write"
1905-
assertThat(kibanaRole.indices().allowedIndicesMatcher(UpdateAction.NAME).test(indexAbstraction), is(true));
1905+
assertThat(kibanaRole.indices().allowedIndicesMatcher(TransportUpdateAction.NAME).test(indexAbstraction), is(true));
19061906

19071907
// Assert Index Management Actions (Allowed by "create_index", "delete_index", and "manage")
19081908
// Allowed by the explicit "create_index" privilege
@@ -1916,12 +1916,6 @@ public void testKibanaSystemRole() {
19161916
is(true)
19171917
);
19181918

1919-
// Assert ILM Actions (Allowed by "manage" and explicit transport actions)
1920-
// Allowed due to the "manage" privilege and explicit TransportUpdateSettingsAction
1921-
assertThat(
1922-
kibanaRole.indices().allowedIndicesMatcher(TransportUpdateSettingsAction.TYPE.name()).test(indexAbstraction),
1923-
is(true)
1924-
);
19251919
// Allowed due to the "manage" privilege and explicit TransportAutoPutMappingAction
19261920
assertThat(
19271921
kibanaRole.indices().allowedIndicesMatcher(TransportPutMappingAction.TYPE.name()).test(indexAbstraction),

0 commit comments

Comments
 (0)