Skip to content

Commit 7e5cacb

Browse files
committed
Use Booleans.parseBoolean(...., false) in case setting is absent
1 parent db42edf commit 7e5cacb

File tree

1 file changed

+6
-6
lines changed

1 file changed

+6
-6
lines changed

x-pack/plugin/watcher/src/test/java/org/elasticsearch/xpack/watcher/rest/action/RestExecuteWatchActionTests.java

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -29,19 +29,19 @@ public class RestExecuteWatchActionTests extends ESTestCase {
2929

3030
public void testThatFlagsCanBeSpecifiedViaParameters() throws Exception {
3131
String randomId = randomAlphaOfLength(10);
32-
for (String recordExecution : Arrays.asList("true", "false")) {
33-
for (String ignoreCondition : Arrays.asList("true", "false")) {
34-
for (String debugCondition : Arrays.asList("true", "false")) {
32+
for (String recordExecution : Arrays.asList("true", "false", null)) {
33+
for (String ignoreCondition : Arrays.asList("true", "false", null)) {
34+
for (String debugCondition : Arrays.asList("true", "false", null)) {
3535

3636
ExecuteWatchRequest request = RestExecuteWatchAction.parseRequest(
3737
createFakeRestRequest(randomId, recordExecution, ignoreCondition, debugCondition),
3838
client
3939
);
4040

4141
assertThat(request.getId(), is(randomId));
42-
assertThat(request.isRecordExecution(), is(Booleans.parseBoolean(recordExecution)));
43-
assertThat(request.isIgnoreCondition(), is(Booleans.parseBoolean(ignoreCondition)));
44-
assertThat(request.isDebug(), is(Booleans.parseBoolean(debugCondition)));
42+
assertThat(request.isRecordExecution(), is(Booleans.parseBoolean(recordExecution, false)));
43+
assertThat(request.isIgnoreCondition(), is(Booleans.parseBoolean(ignoreCondition, false)));
44+
assertThat(request.isDebug(), is(Booleans.parseBoolean(debugCondition, false)));
4545
}
4646
}
4747
}

0 commit comments

Comments
 (0)