Adjust details in the SourceFieldMapper deprecation warning

Author: gmarouli

server/src/main/java/org/elasticsearch/index/mapper/SourceFieldMapper.java

@@ -58,7 +58,9 @@ public class SourceFieldMapper extends MetadataFieldMapper {
 
     public static final String LOSSY_PARAMETERS_ALLOWED_SETTING_NAME = "index.lossy.source-mapping-parameters";
 
-    public static final String DEPRECATION_WARNING = "Configuring source mode in mappings is deprecated and will be removed "
+    public static final String DEPRECATION_WARNING = "Configuring source mode in mappings is deprecated.";
+
+    public static final String DEPRECATION_DETAILS = "Configuring source mode in mappings is deprecated and will be removed "
         + "in future versions. Use [index.mapping.source.mode] index setting instead.";
 
     /** The source mode */

x-pack/plugin/deprecation/src/main/java/org/elasticsearch/xpack/deprecation/TemplateDeprecationChecker.java

@@ -124,7 +124,7 @@ private DeprecationIssue checkSourceModeInComponentTemplates(ComponentTemplate t
                             DeprecationIssue.Level.CRITICAL,
                             SourceFieldMapper.DEPRECATION_WARNING,
                             "https://github.com/elastic/elasticsearch/pull/117172",
-                            null,
+                            SourceFieldMapper.DEPRECATION_DETAILS,
                             false,
                             null
                         );

x-pack/plugin/deprecation/src/test/java/org/elasticsearch/xpack/deprecation/TemplateDeprecationCheckerTests.java

@@ -53,7 +53,7 @@ public void testCheckSourceModeInComponentTemplates() throws IOException {
             DeprecationIssue.Level.CRITICAL,
             SourceFieldMapper.DEPRECATION_WARNING,
             "https://github.com/elastic/elasticsearch/pull/117172",
-            null,
+            SourceFieldMapper.DEPRECATION_DETAILS,
             false,
             null
         );