Enable online prewarming for guice injection (#127338)

This hooks up the OnlinePrewarmingService implementation for guice
injection (and enables us to lookup the implementation in ITs using
the internalCluster.getInstance methods)

Author: andreidan

server/src/main/java/org/elasticsearch/node/NodeConstruction.java

@@ -23,6 +23,8 @@
 import org.elasticsearch.action.bulk.IncrementalBulkService;
 import org.elasticsearch.action.datastreams.autosharding.DataStreamAutoShardingService;
 import org.elasticsearch.action.ingest.ReservedPipelineAction;
+import org.elasticsearch.action.search.OnlinePrewarmingService;
+import org.elasticsearch.action.search.OnlinePrewarmingServiceProvider;
 import org.elasticsearch.action.search.SearchExecutionStatsCollector;
 import org.elasticsearch.action.search.SearchPhaseController;
 import org.elasticsearch.action.search.SearchTransportService;
@@ -1166,6 +1168,10 @@ public Map<String, String> queryFields() {
         final NodeMetrics nodeMetrics = new NodeMetrics(telemetryProvider.getMeterRegistry(), nodeService, metricsInterval);
         final IndicesMetrics indicesMetrics = new IndicesMetrics(telemetryProvider.getMeterRegistry(), indicesService, metricsInterval);
 
+        OnlinePrewarmingService onlinePrewarmingService = pluginsService.loadSingletonServiceProvider(
+            OnlinePrewarmingServiceProvider.class,
+            () -> OnlinePrewarmingServiceProvider.DEFAULT
+        ).create(clusterService.getSettings(), threadPool, clusterService);
         final SearchService searchService = serviceProvider.newSearchService(
             pluginsService,
             clusterService,
@@ -1176,7 +1182,8 @@ public Map<String, String> queryFields() {
             searchModule.getFetchPhase(),
             circuitBreakerService,
             systemIndices.getExecutorSelector(),
-            telemetryProvider.getTracer()
+            telemetryProvider.getTracer(),
+            onlinePrewarmingService
         );
 
         final ShutdownPrepareService shutdownPrepareService = new ShutdownPrepareService(settings, httpServerTransport, terminationHandler);
@@ -1270,6 +1277,7 @@ public Map<String, String> queryFields() {
             b.bind(DataStreamAutoShardingService.class).toInstance(dataStreamAutoShardingService);
             b.bind(FailureStoreMetrics.class).toInstance(failureStoreMetrics);
             b.bind(ShutdownPrepareService.class).toInstance(shutdownPrepareService);
+            b.bind(OnlinePrewarmingService.class).toInstance(onlinePrewarmingService);
         });
 
         if (ReadinessService.enabled(environment)) {

server/src/main/java/org/elasticsearch/node/NodeServiceProvider.java

@@ -10,7 +10,6 @@
 package org.elasticsearch.node;
 
 import org.elasticsearch.action.search.OnlinePrewarmingService;
-import org.elasticsearch.action.search.OnlinePrewarmingServiceProvider;
 import org.elasticsearch.client.internal.node.NodeClient;
 import org.elasticsearch.cluster.ClusterInfoService;
 import org.elasticsearch.cluster.InternalClusterInfoService;
@@ -123,12 +122,9 @@ SearchService newSearchService(
         FetchPhase fetchPhase,
         CircuitBreakerService circuitBreakerService,
         ExecutorSelector executorSelector,
-        Tracer tracer
+        Tracer tracer,
+        OnlinePrewarmingService onlinePrewarmingService
     ) {
-        OnlinePrewarmingService onlinePrewarmingService = pluginsService.loadSingletonServiceProvider(
-            OnlinePrewarmingServiceProvider.class,
-            () -> OnlinePrewarmingServiceProvider.DEFAULT
-        ).create(clusterService.getSettings(), threadPool, clusterService);
         return new SearchService(
             clusterService,
             indicesService,

test/framework/src/main/java/org/elasticsearch/node/MockNode.java

@@ -10,7 +10,6 @@
 package org.elasticsearch.node;
 
 import org.elasticsearch.action.search.OnlinePrewarmingService;
-import org.elasticsearch.action.search.OnlinePrewarmingServiceProvider;
 import org.elasticsearch.client.internal.node.NodeClient;
 import org.elasticsearch.cluster.ClusterInfoService;
 import org.elasticsearch.cluster.MockInternalClusterInfoService;
@@ -103,7 +102,8 @@ SearchService newSearchService(
             FetchPhase fetchPhase,
             CircuitBreakerService circuitBreakerService,
             ExecutorSelector executorSelector,
-            Tracer tracer
+            Tracer tracer,
+            OnlinePrewarmingService onlinePrewarmingService
         ) {
             if (pluginsService.filterPlugins(MockSearchService.TestPlugin.class).findAny().isEmpty()) {
                 return super.newSearchService(
@@ -116,13 +116,11 @@ SearchService newSearchService(
                     fetchPhase,
                     circuitBreakerService,
                     executorSelector,
-                    tracer
+                    tracer,
+                    onlinePrewarmingService
                 );
             }
-            OnlinePrewarmingService onlinePrewarmingService = pluginsService.loadSingletonServiceProvider(
-                OnlinePrewarmingServiceProvider.class,
-                () -> OnlinePrewarmingServiceProvider.DEFAULT
-            ).create(clusterService.getSettings(), threadPool, clusterService);
+
             return new MockSearchService(
                 clusterService,
                 indicesService,