Skip to content

Commit 8056fde

Browse files
committed
Fix test can fail if byte or bit vectors are not supported
1 parent 44ace1a commit 8056fde

File tree

1 file changed

+4
-6
lines changed

1 file changed

+4
-6
lines changed

x-pack/plugin/esql/src/test/java/org/elasticsearch/xpack/esql/analysis/AnalyzerTests.java

Lines changed: 4 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -3807,20 +3807,18 @@ public void testTextEmbeddingFunctionWithoutModel() {
38073807
}
38083808

38093809
public void testKnnFunctionWithTextEmbedding() {
3810-
assumeTrue("dense_vector capability not available", EsqlCapabilities.Cap.KNN_FUNCTION_V5.isEnabled());
3810+
assumeTrue("KNN function capability required", EsqlCapabilities.Cap.KNN_FUNCTION_V5.isEnabled());
38113811
assumeTrue("TEXT_EMBEDDING function required", EsqlCapabilities.Cap.TEXT_EMBEDDING_FUNCTION.isEnabled());
38123812

3813-
String fieldName = randomFrom("float_vector", "byte_vector");
3814-
38153813
LogicalPlan plan = analyze("""
3816-
from test | where KNN(%s, TEXT_EMBEDDING("italian food recipe", "%s"))
3817-
""".formatted(fieldName, TEXT_EMBEDDING_INFERENCE_ID), "mapping-dense_vector.json");
3814+
from test | where KNN(float_vector, TEXT_EMBEDDING("italian food recipe", "%s"))
3815+
""".formatted(TEXT_EMBEDDING_INFERENCE_ID), "mapping-dense_vector.json");
38183816

38193817
Limit limit = as(plan, Limit.class);
38203818
Filter filter = as(limit.child(), Filter.class);
38213819
Knn knn = as(filter.condition(), Knn.class);
38223820
assertThat(knn.field(), instanceOf(FieldAttribute.class));
3823-
assertThat(((FieldAttribute) knn.field()).name(), equalTo(fieldName));
3821+
assertThat(((FieldAttribute) knn.field()).name(), equalTo("float_vector"));
38243822

38253823
TextEmbedding textEmbedding = as(knn.query(), TextEmbedding.class);
38263824
assertThat(textEmbedding.inputText(), equalTo(string("italian food recipe")));

0 commit comments

Comments
 (0)