Don't use discretize to calculate dimensions, removed quantized dimensions

Author: carlosdelest

server/src/main/java/org/elasticsearch/index/codec/vectors/es910/ES910BinaryFlatVectorsScorer.java

@@ -72,9 +72,8 @@ public RandomVectorScorer getRandomVectorScorer(
             if (similarityFunction == COSINE) {
                 VectorUtil.l2normalize(copy);
             }
-            target = copy;
-            byte[] quantized = new byte[target.length];
-            OptimizedScalarQuantizer.QuantizationResult queryCorrections = quantizer.scalarQuantize(target, quantized, queryBits, centroid);
+            byte[] quantized = new byte[copy.length];
+            OptimizedScalarQuantizer.QuantizationResult queryCorrections = quantizer.scalarQuantize(copy, quantized, queryBits, centroid);
             return new RandomVectorScorer.AbstractRandomVectorScorer(vectorValues) {
                 @Override
                 public float score(int i) throws IOException {
@@ -168,7 +167,7 @@ public static class BinarizedRandomVectorScorer extends UpdateableRandomVectorSc
         ) {
             super(targetVectors);
             this.queryVectors = queryVectors;
-            this.quantizedQuery = new byte[queryVectors.quantizedDimension()];
+            this.quantizedQuery = new byte[queryVectors.dimension()];
             this.targetVectors = targetVectors;
             this.similarityFunction = similarityFunction;
             bitScale = 1.0F / (float) ((1 << queryBits) - 1);

server/src/main/java/org/elasticsearch/index/codec/vectors/es910/ES910BinaryQuantizedVectorsWriter.java

@@ -46,8 +46,6 @@
 import org.apache.lucene.util.hnsw.RandomVectorScorerSupplier;
 import org.apache.lucene.util.hnsw.UpdateableRandomVectorScorer;
 import org.elasticsearch.core.SuppressForbidden;
-import org.elasticsearch.index.codec.vectors.BQSpaceUtils;
-import org.elasticsearch.index.codec.vectors.BQVectorUtils;
 import org.elasticsearch.index.codec.vectors.OptimizedScalarQuantizer;
 
 import java.io.Closeable;
@@ -737,13 +735,11 @@ static class OffHeapBinarizedQueryVectorValues {
             this.slice = data;
             this.dimension = dimension;
             this.size = size;
-            // 4x the quantized binary dimensions
-            int binaryDimensions = (BQVectorUtils.discretize(dimension, 64) / 8) * BQSpaceUtils.B_QUERY;
-            this.byteBuffer = ByteBuffer.allocate(binaryDimensions);
+            this.byteBuffer = ByteBuffer.allocate(dimension);
             this.binaryValue = byteBuffer.array();
             // + 1 for the quantized sum
             this.correctiveValues = new float[3];
-            this.byteSize = binaryDimensions + Float.BYTES * 3 + Short.BYTES;
+            this.byteSize = dimension + Float.BYTES * 3 + Short.BYTES;
         }
 
         public OptimizedScalarQuantizer.QuantizationResult getCorrectiveTerms(int targetOrd) throws IOException {
@@ -764,10 +760,6 @@ public OptimizedScalarQuantizer.QuantizationResult getCorrectiveTerms(int target
             );
         }
 
-        int quantizedDimension() {
-            return byteBuffer.array().length;
-        }
-
         public int size() {
             return size;
         }

server/src/main/java/org/elasticsearch/index/codec/vectors/es910/OffHeapBinarizedVectorValues.java

@@ -29,7 +29,6 @@
 import org.apache.lucene.util.Bits;
 import org.apache.lucene.util.hnsw.RandomVectorScorer;
 import org.apache.lucene.util.packed.DirectMonotonicReader;
-import org.elasticsearch.index.codec.vectors.BQVectorUtils;
 import org.elasticsearch.index.codec.vectors.OptimizedScalarQuantizer;
 
 import java.io.IOException;
@@ -53,7 +52,6 @@ abstract class OffHeapBinarizedVectorValues extends BinarizedByteVectorValues {
     final OptimizedScalarQuantizer binaryQuantizer;
     final float[] centroid;
     final float centroidDp;
-    private final int discretizedDimensions;
 
     OffHeapBinarizedVectorValues(
         int dimension,
@@ -77,7 +75,6 @@ abstract class OffHeapBinarizedVectorValues extends BinarizedByteVectorValues {
         this.byteBuffer = ByteBuffer.allocate(dimension);
         this.binaryValue = byteBuffer.array();
         this.binaryQuantizer = quantizer;
-        this.discretizedDimensions = BQVectorUtils.discretize(dimension, 64);
     }
 
     @Override