Experiment with also avoiding mmap for fdm and fdx tmp files.

Author: martijnvg

server/src/main/java/org/elasticsearch/index/store/FsDirectoryFactory.java

@@ -233,8 +233,8 @@ static boolean useDelegate(String name, IOContext ioContext) {
         }
 
         /**
-         * Force not using mmap if file is tmp fdt file.
-         * The tmp fdt file only gets created when flushing stored
+         * Force not using mmap if file is tmp fdm, fdx and fdt files.
+         * The tmp fdm, fdx, fdt file only gets created when flushing stored
          * fields to disk and index sorting is active.
          * <p>
          * In Lucene, the <code>SortingStoredFieldsConsumer</code> first
@@ -252,17 +252,17 @@ static boolean useDelegate(String name, IOContext ioContext) {
          * <p>
          * As part of flushing stored disk when indexing sorting is active,
          * three tmp files are created, fdm (metadata), fdx (index) and
-         * fdt (contains stored field data). The first two files are small and
-         * mmap-ing that should still be ok even is memory is scarce.
-         * The fdt file is large and tends to cause more page faults when memory is scarce.
+         * fdt (contains stored field data). All tmp files avoid using mmmp directory.
          *
          * @param name      The name of the file in Lucene index
          * @param extension The extension of the in Lucene index
          * @return whether to avoid using delegate if the file is a tmp fdt file.
          */
         static boolean avoidDelegateForFdtTempFiles(String name, LuceneFilesExtensions extension) {
             // NOTE, for now gated behind feature flag to observe impact of this change in benchmarks only:
-            return TMP_FDT_NO_MMAP_FEATURE_FLAG.isEnabled() && extension == LuceneFilesExtensions.TMP && name.contains("fdt");
+            return TMP_FDT_NO_MMAP_FEATURE_FLAG.isEnabled()
+                && extension == LuceneFilesExtensions.TMP
+                && (name.contains("fdt") || name.contains("fdx") || name.contains("fdm"));
         }
 
         MMapDirectory getDelegate() {

server/src/test/java/org/elasticsearch/index/store/FsDirectoryFactoryTests.java

@@ -71,8 +71,8 @@ public void testPreload() throws IOException {
             assertTrue(FsDirectoryFactory.HybridDirectory.useDelegate("foo.tmp", newIOContext(random())));
             assertFalse(FsDirectoryFactory.HybridDirectory.useDelegate("foo.fdt__0.tmp", newIOContext(random())));
             assertFalse(FsDirectoryFactory.HybridDirectory.useDelegate("_0.fdt__1.tmp", newIOContext(random())));
-            assertTrue(FsDirectoryFactory.HybridDirectory.useDelegate("_0.fdm__0.tmp", newIOContext(random())));
-            assertTrue(FsDirectoryFactory.HybridDirectory.useDelegate("_0.fdx__4.tmp", newIOContext(random())));
+            assertFalse(FsDirectoryFactory.HybridDirectory.useDelegate("_0.fdm__0.tmp", newIOContext(random())));
+            assertFalse(FsDirectoryFactory.HybridDirectory.useDelegate("_0.fdx__4.tmp", newIOContext(random())));
             MMapDirectory delegate = hybridDirectory.getDelegate();
             assertThat(delegate, Matchers.instanceOf(MMapDirectory.class));
             var func = fsDirectoryFactory.preLoadFuncMap.get(delegate);