Use Booleans.parseBooleanLenient instead of @SuppressForbidden for permanent lenient usage

Author: kvanerum

libs/core/src/main/java/org/elasticsearch/core/internal/provider/EmbeddedImplClassLoader.java

@@ -9,7 +9,7 @@
 
 package org.elasticsearch.core.internal.provider;
 
-import org.elasticsearch.core.SuppressForbidden;
+import org.elasticsearch.core.Booleans;
 
 import java.io.BufferedReader;
 import java.io.IOException;
@@ -467,12 +467,11 @@ private static CodeSource codeSource(URL baseURL, String jarName) throws Malform
         return new CodeSource(new URL(baseURL, jarName), (CodeSigner[]) null /*signers*/);
     }
 
-    @SuppressForbidden(reason = "accept lenient manifest attributes")
     private static boolean isMultiRelease(ClassLoader parent, String jarPrefix) throws IOException {
         try (InputStream is = parent.getResourceAsStream(jarPrefix + "/META-INF/MANIFEST.MF")) {
             if (is != null) {
                 Manifest manifest = new Manifest(is);
-                return Boolean.parseBoolean(manifest.getMainAttributes().getValue(MULTI_RELEASE));
+                return Booleans.parseBooleanLenient(manifest.getMainAttributes().getValue(MULTI_RELEASE), false);
             }
         }
         return false;

x-pack/plugin/core/src/main/java/org/elasticsearch/xpack/core/ml/inference/trainedmodel/PredictionFieldType.java

@@ -11,7 +11,7 @@
 import org.elasticsearch.common.io.stream.StreamInput;
 import org.elasticsearch.common.io.stream.StreamOutput;
 import org.elasticsearch.common.io.stream.Writeable;
-import org.elasticsearch.core.SuppressForbidden;
+import org.elasticsearch.core.Booleans;
 
 import java.io.IOException;
 import java.util.Locale;
@@ -62,7 +62,7 @@ public Object transformPredictedValue(Double value, String stringRep) {
                         // do nothing, allow fall through to final fromDouble
                     }
                 } else if (isBoolQuickCheck(stringRep)) { // if we start with t/f case insensitive, it indicates boolean string
-                    return parseBoolean(stringRep);
+                    return Booleans.parseBooleanLenient(stringRep, false);
                 }
                 return fromDouble(value);
             case NUMBER:
@@ -81,11 +81,6 @@ public Object transformPredictedValue(Double value, String stringRep) {
         }
     }
 
-    @SuppressForbidden(reason = "accept lenient boolean field values")
-    private static boolean parseBoolean(String value) {
-        return Boolean.parseBoolean(value);
-    }
-
     private static boolean fromDouble(double value) {
         if ((areClose(value, 1.0D) || areClose(value, 0.0D)) == false) {
             throw new IllegalArgumentException(

x-pack/plugin/esql/src/main/java/org/elasticsearch/xpack/esql/type/EsqlDataTypeConverter.java

@@ -21,7 +21,7 @@
 import org.elasticsearch.compute.data.AggregateMetricDoubleBlockBuilder.Metric;
 import org.elasticsearch.compute.data.DoubleBlock;
 import org.elasticsearch.compute.data.IntBlock;
-import org.elasticsearch.core.SuppressForbidden;
+import org.elasticsearch.core.Booleans;
 import org.elasticsearch.search.DocValueFormat;
 import org.elasticsearch.xcontent.XContentBuilder;
 import org.elasticsearch.xcontent.json.JsonXContent;
@@ -600,11 +600,8 @@ public static BytesRef numericBooleanToString(Object field) {
         return new BytesRef(String.valueOf(field));
     }
 
-    @SuppressForbidden(
-        reason = "https://www.elastic.co/docs/reference/query-languages/esql/functions-operators/type-conversion-functions#esql-to_boolean"
-    )
     public static boolean stringToBoolean(String field) {
-        return Boolean.parseBoolean(field);
+        return Booleans.parseBooleanLenient(field, false);
     }
 
     public static int stringToInt(String field) {

x-pack/plugin/sql/jdbc/src/main/java/org/elasticsearch/xpack/sql/jdbc/TypeConverter.java

@@ -6,8 +6,8 @@
  */
 package org.elasticsearch.xpack.sql.jdbc;
 
-import org.elasticsearch.xpack.sql.client.SuppressForbidden;
 import org.elasticsearch.xpack.sql.proto.StringUtils;
+import org.elasticsearch.xpack.sql.proto.core.Booleans;
 
 import java.math.BigDecimal;
 import java.math.BigInteger;
@@ -311,7 +311,6 @@ private static <T> T failConversion(Object value, EsType columnType, String type
         throw e != null ? new SQLException(message, e) : new SQLException(message);
     }
 
-    @SuppressForbidden(reason = "allow lenient conversion to boolean")
     private static Boolean asBoolean(Object val, EsType columnType, String typeString) throws SQLException {
         switch (columnType) {
             case BOOLEAN:
@@ -327,7 +326,7 @@ private static Boolean asBoolean(Object val, EsType columnType, String typeStrin
                 return Boolean.valueOf(((Number) val).doubleValue() != 0);
             case KEYWORD:
             case TEXT:
-                return Boolean.valueOf((String) val);
+                return Booleans.parseBooleanLenient((String) val, false);
             default:
                 return failConversion(val, columnType, typeString, Boolean.class);
         }