Fix search response leaks in EQL tests (#103068)

Fixing all EQL tests

Author: original-brownbear

x-pack/plugin/eql/src/test/java/org/elasticsearch/xpack/eql/execution/assembler/ImplicitTiebreakerTests.java

@@ -84,8 +84,7 @@ public void query(QueryRequest r, ActionListener<SearchResponse> l) {
             );
             SearchHits searchHits = new SearchHits(new SearchHit[] { searchHit }, new TotalHits(1, Relation.EQUAL_TO), 0.0f);
             SearchResponseSections internal = new SearchResponseSections(searchHits, null, null, false, false, null, 0);
-            SearchResponse s = new SearchResponse(internal, null, 0, 1, 0, 0, null, Clusters.EMPTY);
-            l.onResponse(s);
+            ActionListener.respondAndRelease(l, new SearchResponse(internal, null, 0, 1, 0, 0, null, Clusters.EMPTY));
         }
 
         @Override

x-pack/plugin/eql/src/test/java/org/elasticsearch/xpack/eql/execution/assembler/SequenceSpecTests.java

@@ -222,8 +222,7 @@ public void query(QueryRequest r, ActionListener<SearchResponse> l) {
                 0.0f
             );
             SearchResponseSections internal = new SearchResponseSections(searchHits, null, null, false, false, null, 0);
-            SearchResponse s = new SearchResponse(internal, null, 0, 1, 0, 0, null, Clusters.EMPTY);
-            l.onResponse(s);
+            ActionListener.respondAndRelease(l, new SearchResponse(internal, null, 0, 1, 0, 0, null, Clusters.EMPTY));
         }
 
         @Override

x-pack/plugin/eql/src/test/java/org/elasticsearch/xpack/eql/execution/sample/CircuitBreakerTests.java

@@ -224,19 +224,20 @@ <Response extends ActionResponse> void handleSearchRequest(ActionListener<Respon
             Aggregations aggs = new Aggregations(List.of(newInternalComposite()));
 
             SearchResponseSections internal = new SearchResponseSections(null, aggs, null, false, false, null, 0);
-            SearchResponse response = new SearchResponse(
-                internal,
-                null,
-                2,
-                0,
-                0,
-                0,
-                ShardSearchFailure.EMPTY_ARRAY,
-                Clusters.EMPTY,
-                searchRequest.pointInTimeBuilder().getEncodedId()
+            ActionListener.respondAndRelease(
+                listener,
+                (Response) new SearchResponse(
+                    internal,
+                    null,
+                    2,
+                    0,
+                    0,
+                    0,
+                    ShardSearchFailure.EMPTY_ARRAY,
+                    Clusters.EMPTY,
+                    searchRequest.pointInTimeBuilder().getEncodedId()
+                )
             );
-
-            listener.onResponse((Response) response);
         }
 
         private InternalComposite newInternalComposite() {

x-pack/plugin/eql/src/test/java/org/elasticsearch/xpack/eql/execution/sequence/CircuitBreakerTests.java

@@ -115,8 +115,7 @@ public void query(QueryRequest r, ActionListener<SearchResponse> l) {
             );
             SearchHits searchHits = new SearchHits(new SearchHit[] { searchHit }, new TotalHits(1, Relation.EQUAL_TO), 0.0f);
             SearchResponseSections internal = new SearchResponseSections(searchHits, null, null, false, false, null, 0);
-            SearchResponse s = new SearchResponse(internal, null, 0, 1, 0, 0, null, Clusters.EMPTY);
-            l.onResponse(s);
+            ActionListener.respondAndRelease(l, new SearchResponse(internal, null, 0, 1, 0, 0, null, Clusters.EMPTY));
         }
 
         @Override
@@ -451,7 +450,7 @@ <Response extends ActionResponse> void handleSearchRequest(ActionListener<Respon
                 assertTrue(circuitBreaker.getUsed() > 0); // at this point the algorithm already started adding up to memory usage
             }
 
-            listener.onResponse((Response) response);
+            ActionListener.respondAndRelease(listener, (Response) response);
         }
     }
 
@@ -479,18 +478,20 @@ <Response extends ActionResponse> void handleSearchRequest(ActionListener<Respon
                 );
                 SearchHits searchHits = new SearchHits(new SearchHit[] { searchHit }, new TotalHits(1, Relation.EQUAL_TO), 0.0f);
                 SearchResponseSections internal = new SearchResponseSections(searchHits, null, null, false, false, null, 0);
-                SearchResponse response = new SearchResponse(
-                    internal,
-                    null,
-                    2,
-                    0,
-                    0,
-                    0,
-                    ShardSearchFailure.EMPTY_ARRAY,
-                    SearchResponse.Clusters.EMPTY,
-                    searchRequest.pointInTimeBuilder().getEncodedId()
+                ActionListener.respondAndRelease(
+                    listener,
+                    (Response) new SearchResponse(
+                        internal,
+                        null,
+                        2,
+                        0,
+                        0,
+                        0,
+                        ShardSearchFailure.EMPTY_ARRAY,
+                        SearchResponse.Clusters.EMPTY,
+                        searchRequest.pointInTimeBuilder().getEncodedId()
+                    )
                 );
-                listener.onResponse((Response) response);
             } else {
                 assertTrue(circuitBreaker.getUsed() > 0); // at this point the algorithm already started adding up to memory usage
                 ShardSearchFailure[] failures = new ShardSearchFailure[] {
@@ -504,28 +505,29 @@ <Response extends ActionResponse> void handleSearchRequest(ActionListener<Respon
                     listener.onFailure(new SearchPhaseExecutionException("search", "all shards failed", failures));
                 } else {
                     // or a partial shard failure
-                    SearchResponse response = new SearchResponse(
-                        new InternalSearchResponse(
-                            new SearchHits(new SearchHit[] { new SearchHit(1) }, new TotalHits(1L, TotalHits.Relation.EQUAL_TO), 1.0f),
+                    // this should still be caught and the exception handled properly and circuit breaker cleared
+                    ActionListener.respondAndRelease(
+                        listener,
+                        (Response) new SearchResponse(
+                            new InternalSearchResponse(
+                                new SearchHits(new SearchHit[] { new SearchHit(1) }, new TotalHits(1L, TotalHits.Relation.EQUAL_TO), 1.0f),
+                                null,
+                                new Suggest(Collections.emptyList()),
+                                new SearchProfileResults(Collections.emptyMap()),
+                                false,
+                                false,
+                                1
+                            ),
                             null,
-                            new Suggest(Collections.emptyList()),
-                            new SearchProfileResults(Collections.emptyMap()),
-                            false,
-                            false,
-                            1
-                        ),
-                        null,
-                        2,
-                        1,
-                        0,
-                        0,
-                        failures,
-                        SearchResponse.Clusters.EMPTY,
-                        searchRequest.pointInTimeBuilder().getEncodedId()
+                            2,
+                            1,
+                            0,
+                            0,
+                            failures,
+                            SearchResponse.Clusters.EMPTY,
+                            searchRequest.pointInTimeBuilder().getEncodedId()
+                        )
                     );
-
-                    // this should still be caught and the exception handled properly and circuit breaker cleared
-                    listener.onResponse((Response) response);
                 }
             }
         }