Skip to content

Commit 85163f1

Browse files
committed
no tolerance for failed individual groups/windows
1 parent 507ceb6 commit 85163f1

File tree

1 file changed

+1
-7
lines changed

1 file changed

+1
-7
lines changed

x-pack/plugin/esql/src/internalClusterTest/java/org/elasticsearch/xpack/esql/action/RandomizedTimeSeriesIT.java

Lines changed: 1 addition & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -260,7 +260,6 @@ static RateStats calculateRateAggregation(
260260
}
261261
lastValue = currentValue; // Update last value for next iteration
262262
}
263-
// TODO: Remove tolerances since we are already allowing a min-max range
264263
return new RateRange(
265264
counterGrowth / secondsInWindow * 0.99, // Add 1% tolerance to the lower bound
266265
1000.0 * counterGrowth / (lastTs.toEpochMilli() - firstTs.toEpochMilli()) * 1.01 // Add 1% tolerance to the upper bound
@@ -332,12 +331,7 @@ void checkWithin(Double actual, RateRange expected) {
332331
}
333332

334333
void assertNoFailedWindows(List<String> failedWindows, List<List<Object>> rows) {
335-
// TODO: WE have a 15% tolerance for failed windows. Must remove.
336-
if (failedWindows.size() < 0.01 * rows.size()) {
337-
logger.warn(
338-
"Failed " + failedWindows.size() + " windows out of " + rows.size() + ", failures:\n" + String.join("\n", failedWindows)
339-
);
340-
} else if (failedWindows.isEmpty() == false) {
334+
if (failedWindows.isEmpty() == false) {
341335
var pctFailures = (double) failedWindows.size() / rows.size() * 100;
342336
var failureDetails = String.join("\n", failedWindows);
343337
if (failureDetails.length() > 2000) {

0 commit comments

Comments
 (0)