Test non-null args

Author: carlosdelest

x-pack/plugin/esql/src/internalClusterTest/java/org/elasticsearch/xpack/esql/vector/VectorSimilarityFunctionsIT.java

@@ -53,7 +53,7 @@ public VectorSimilarityFunctionsIT(
     }
 
     @SuppressWarnings("unchecked")
-    public void testCosineSimilarityBetweenVectors() {
+    public void testSimilarityBetweenVectors() {
         var query = String.format(Locale.ROOT, """
                 FROM test
                 | EVAL similarity = %s(left_vector, right_vector)
@@ -75,7 +75,7 @@ public void testCosineSimilarityBetweenVectors() {
     }
 
     @SuppressWarnings("unchecked")
-    public void testCosineSimilarityBetweenConstantVectorAndField() {
+    public void testSimilarityBetweenConstantVectorAndField() {
         var randomVector = randomVectorArray();
         var query = String.format(Locale.ROOT, """
                 FROM test
@@ -97,7 +97,7 @@ public void testCosineSimilarityBetweenConstantVectorAndField() {
     }
 
     @SuppressWarnings("unchecked")
-    public void testCosineSimilarityBetweenConstantVectors() {
+    public void testSimilarityBetweenConstantVectors() {
         var vectorLeft = randomVectorArray();
         var vectorRight = randomVectorArray();
         var query = String.format(Locale.ROOT, """

x-pack/plugin/esql/src/main/java/org/elasticsearch/xpack/esql/expression/function/vector/VectorSimilarityFunction.java

@@ -15,6 +15,7 @@
 import org.elasticsearch.compute.operator.DriverContext;
 import org.elasticsearch.compute.operator.EvalOperator;
 import org.elasticsearch.xpack.esql.core.expression.Expression;
+import org.elasticsearch.xpack.esql.core.expression.TypeResolutions;
 import org.elasticsearch.xpack.esql.core.tree.Source;
 import org.elasticsearch.xpack.esql.core.type.DataType;
 import org.elasticsearch.xpack.esql.expression.function.scalar.EsqlScalarFunction;
@@ -23,6 +24,7 @@
 import java.util.List;
 
 import static org.elasticsearch.xpack.esql.core.expression.TypeResolutions.ParamOrdinal.FIRST;
+import static org.elasticsearch.xpack.esql.core.expression.TypeResolutions.ParamOrdinal.SECOND;
 import static org.elasticsearch.xpack.esql.core.expression.TypeResolutions.isNotNull;
 import static org.elasticsearch.xpack.esql.core.expression.TypeResolutions.isType;
 import static org.elasticsearch.xpack.esql.core.type.DataType.DENSE_VECTOR;
@@ -59,11 +61,11 @@ protected TypeResolution resolveType() {
             return new TypeResolution("Unresolved children");
         }
 
-        return checkDenseVectorParam(left()).and(checkDenseVectorParam(right()));
+        return checkDenseVectorParam(left(), FIRST).and(checkDenseVectorParam(right(), SECOND));
     }
 
-    private TypeResolution checkDenseVectorParam(Expression param) {
-        return isNotNull(param, sourceText(), FIRST).and(isType(param, dt -> dt == DENSE_VECTOR, sourceText(), FIRST, "dense_vector"));
+    private TypeResolution checkDenseVectorParam(Expression param, TypeResolutions.ParamOrdinal paramOrdinal) {
+        return isNotNull(param, sourceText(), paramOrdinal).and(isType(param, dt -> dt == DENSE_VECTOR, sourceText(), paramOrdinal, "dense_vector"));
     }
 
     @Override

x-pack/plugin/esql/src/test/java/org/elasticsearch/xpack/esql/analysis/VerifierTests.java

@@ -2236,6 +2236,20 @@ private void checkFullTextFunctionsInStats(String functionInvocation) {
         );
     }
 
+    public void testVectorSimilarityFunctionsNullArgs() throws Exception {
+        if (EsqlCapabilities.Cap.COSINE_VECTOR_SIMILARITY_FUNCTION.isEnabled()) {
+            checkVectorSimilarityFunctionsNullArgs("v_cosine_similarity(null, vector)", "first");
+            checkVectorSimilarityFunctionsNullArgs("v_cosine_similarity(vector, null)", "second");
+        }
+    }
+
+    private void checkVectorSimilarityFunctionsNullArgs(String functionInvocation, String argOrdinal) throws Exception {
+        assertThat(
+            error("from test | eval similarity = " + functionInvocation, fullTextAnalyzer),
+            containsString(argOrdinal + " argument of [" + functionInvocation + "] cannot be null, received [null]")
+        );
+    }
+
     private void query(String query) {
         query(query, defaultAnalyzer);
     }