add explanation to canRemain method to fix testing

DiannaHohensee · DiannaHohensee · commit 85f444872209 · 2025-08-14T15:16:43.000-07:00
diff --git a/server/src/main/java/org/elasticsearch/cluster/routing/allocation/decider/WriteLoadConstraintDecider.java b/server/src/main/java/org/elasticsearch/cluster/routing/allocation/decider/WriteLoadConstraintDecider.java
@@ -101,12 +101,12 @@ public Decision canAllocate(ShardRouting shardRouting, RoutingNode node, Routing
     @Override
     public Decision canRemain(IndexMetadata indexMetadata, ShardRouting shardRouting, RoutingNode node, RoutingAllocation allocation) {
         if (writeLoadConstraintSettings.getWriteLoadConstraintEnabled().notFullyEnabled()) {
-            return Decision.YES;
+            return Decision.single(Decision.Type.YES, NAME, "canRemain() is not enabled");
         }
 
         // TODO: implement
 
-        return Decision.YES;
+        return Decision.single(Decision.Type.YES, NAME, "canRemain() is not yet implemented");
     }
 
     /**

Original file line number	Diff line number	Diff line change
`@@ -101,12 +101,12 @@ public Decision canAllocate(ShardRouting shardRouting, RoutingNode node, Routing`
`101`	`101`	`@Override`
`102`	`102`	`public Decision canRemain(IndexMetadata indexMetadata, ShardRouting shardRouting, RoutingNode node, RoutingAllocation allocation) {`
`103`	`103`	`if (writeLoadConstraintSettings.getWriteLoadConstraintEnabled().notFullyEnabled()) {`
`104`		`- return Decision.YES;`
	`104`	`+ return Decision.single(Decision.Type.YES, NAME, "canRemain() is not enabled");`
`105`	`105`	`}`
`106`	`106`
`107`	`107`	`// TODO: implement`
`108`	`108`
`109`		`- return Decision.YES;`
	`109`	`+ return Decision.single(Decision.Type.YES, NAME, "canRemain() is not yet implemented");`
`110`	`110`	`}`
`111`	`111`
`112`	`112`	`/**`