Addressing feedback for validation exception

Author: jonathan-buttner

x-pack/plugin/inference/src/main/java/org/elasticsearch/xpack/inference/services/custom/response/CompletionResponseParser.java

@@ -33,7 +33,7 @@ public class CompletionResponseParser extends BaseCustomResponseParser<ChatCompl
     public static CompletionResponseParser fromMap(Map<String, Object> responseParserMap, ValidationException validationException) {
         var path = extractRequiredString(responseParserMap, COMPLETION_PARSER_RESULT, JSON_PARSER, validationException);
 
-        if (path == null) {
+        if (validationException.validationErrors().isEmpty() == false) {
             throw validationException;
         }
 

x-pack/plugin/inference/src/main/java/org/elasticsearch/xpack/inference/services/custom/response/ErrorResponseParser.java

@@ -38,7 +38,7 @@ public class ErrorResponseParser implements ToXContentFragment, Function<HttpRes
     public static ErrorResponseParser fromMap(Map<String, Object> responseParserMap, ValidationException validationException) {
         var path = extractRequiredString(responseParserMap, MESSAGE_PATH, ERROR_PARSER, validationException);
 
-        if (path == null) {
+        if (validationException.validationErrors().isEmpty() == false) {
             throw validationException;
         }
 

x-pack/plugin/inference/src/main/java/org/elasticsearch/xpack/inference/services/custom/response/NoopResponseParser.java

@@ -24,10 +24,6 @@ public static NoopResponseParser fromMap() {
         return new NoopResponseParser();
     }
 
-    public NoopResponseParser() {
-
-    }
-
     public NoopResponseParser(StreamInput in) {
         this();
     }

x-pack/plugin/inference/src/main/java/org/elasticsearch/xpack/inference/services/custom/response/RerankResponseParser.java

@@ -43,7 +43,7 @@ public static RerankResponseParser fromMap(Map<String, Object> responseParserMap
         var rerankIndex = extractOptionalString(responseParserMap, RERANK_PARSER_INDEX, JSON_PARSER, validationException);
         var documentText = extractOptionalString(responseParserMap, RERANK_PARSER_DOCUMENT_TEXT, JSON_PARSER, validationException);
 
-        if (relevanceScore == null) {
+        if (validationException.validationErrors().isEmpty() == false) {
             throw validationException;
         }
 

x-pack/plugin/inference/src/main/java/org/elasticsearch/xpack/inference/services/custom/response/SparseEmbeddingResponseParser.java

@@ -40,7 +40,7 @@ public static SparseEmbeddingResponseParser fromMap(Map<String, Object> response
 
         var weightPath = extractRequiredString(responseParserMap, SPARSE_EMBEDDING_WEIGHT_PATH, JSON_PARSER, validationException);
 
-        if (tokenPath == null || weightPath == null) {
+        if (validationException.validationErrors().isEmpty() == false) {
             throw validationException;
         }
 

x-pack/plugin/inference/src/main/java/org/elasticsearch/xpack/inference/services/custom/response/TextEmbeddingResponseParser.java

@@ -33,7 +33,7 @@ public class TextEmbeddingResponseParser extends BaseCustomResponseParser<TextEm
     public static TextEmbeddingResponseParser fromMap(Map<String, Object> responseParserMap, ValidationException validationException) {
         var path = extractRequiredString(responseParserMap, TEXT_EMBEDDING_PARSER_EMBEDDINGS, JSON_PARSER, validationException);
 
-        if (path == null) {
+        if (validationException.validationErrors().isEmpty() == false) {
             throw validationException;
         }