Skip to content

Commit 86d477e

Browse files
author
Max Hniebergall
committed
get the build working
1 parent cb440e1 commit 86d477e

File tree

6 files changed

+61
-7
lines changed

6 files changed

+61
-7
lines changed

x-pack/plugin/inference/qa/test-service-plugin/src/main/java/org/elasticsearch/xpack/inference/mock/TestDenseInferenceServiceExtension.java

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -32,6 +32,7 @@
3232
import org.elasticsearch.inference.SimilarityMeasure;
3333
import org.elasticsearch.inference.TaskSettingsConfiguration;
3434
import org.elasticsearch.inference.TaskType;
35+
import org.elasticsearch.inference.UnifiedCompletionRequest;
3536
import org.elasticsearch.inference.configuration.SettingsConfigurationDisplayType;
3637
import org.elasticsearch.inference.configuration.SettingsConfigurationFieldType;
3738
import org.elasticsearch.rest.RestStatus;
@@ -133,6 +134,16 @@ public void infer(
133134
}
134135
}
135136

137+
@Override
138+
public void unifiedCompletionInfer(
139+
Model model,
140+
UnifiedCompletionRequest request,
141+
TimeValue timeout,
142+
ActionListener<InferenceServiceResults> listener
143+
) {
144+
listener.onFailure(new UnsupportedOperationException("unifiedCompletionInfer not supported"));
145+
}
146+
136147
@Override
137148
public void chunkedInfer(
138149
Model model,

x-pack/plugin/inference/qa/test-service-plugin/src/main/java/org/elasticsearch/xpack/inference/mock/TestRerankingServiceExtension.java

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -30,6 +30,7 @@
3030
import org.elasticsearch.inference.SettingsConfiguration;
3131
import org.elasticsearch.inference.TaskSettingsConfiguration;
3232
import org.elasticsearch.inference.TaskType;
33+
import org.elasticsearch.inference.UnifiedCompletionRequest;
3334
import org.elasticsearch.inference.configuration.SettingsConfigurationDisplayType;
3435
import org.elasticsearch.inference.configuration.SettingsConfigurationFieldType;
3536
import org.elasticsearch.rest.RestStatus;
@@ -121,6 +122,16 @@ public void infer(
121122
}
122123
}
123124

125+
@Override
126+
public void unifiedCompletionInfer(
127+
Model model,
128+
UnifiedCompletionRequest request,
129+
TimeValue timeout,
130+
ActionListener<InferenceServiceResults> listener
131+
) {
132+
listener.onFailure(new UnsupportedOperationException("unifiedCompletionInfer not supported"));
133+
}
134+
124135
@Override
125136
public void chunkedInfer(
126137
Model model,

x-pack/plugin/inference/qa/test-service-plugin/src/main/java/org/elasticsearch/xpack/inference/mock/TestSparseInferenceServiceExtension.java

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -30,6 +30,7 @@
3030
import org.elasticsearch.inference.SettingsConfiguration;
3131
import org.elasticsearch.inference.TaskSettingsConfiguration;
3232
import org.elasticsearch.inference.TaskType;
33+
import org.elasticsearch.inference.UnifiedCompletionRequest;
3334
import org.elasticsearch.inference.configuration.SettingsConfigurationDisplayType;
3435
import org.elasticsearch.inference.configuration.SettingsConfigurationFieldType;
3536
import org.elasticsearch.rest.RestStatus;
@@ -124,6 +125,16 @@ public void infer(
124125
}
125126
}
126127

128+
@Override
129+
public void unifiedCompletionInfer(
130+
Model model,
131+
UnifiedCompletionRequest request,
132+
TimeValue timeout,
133+
ActionListener<InferenceServiceResults> listener
134+
) {
135+
throw new UnsupportedOperationException("unifiedCompletionInfer not supported");
136+
}
137+
127138
@Override
128139
public void chunkedInfer(
129140
Model model,

x-pack/plugin/inference/qa/test-service-plugin/src/main/java/org/elasticsearch/xpack/inference/mock/TestStreamingCompletionServiceExtension.java

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -31,6 +31,7 @@
3131
import org.elasticsearch.inference.SettingsConfiguration;
3232
import org.elasticsearch.inference.TaskSettingsConfiguration;
3333
import org.elasticsearch.inference.TaskType;
34+
import org.elasticsearch.inference.UnifiedCompletionRequest;
3435
import org.elasticsearch.inference.configuration.SettingsConfigurationDisplayType;
3536
import org.elasticsearch.inference.configuration.SettingsConfigurationFieldType;
3637
import org.elasticsearch.rest.RestStatus;
@@ -122,6 +123,16 @@ public void infer(
122123
}
123124
}
124125

126+
@Override
127+
public void unifiedCompletionInfer(
128+
Model model,
129+
UnifiedCompletionRequest request,
130+
TimeValue timeout,
131+
ActionListener<InferenceServiceResults> listener
132+
) {
133+
listener.onFailure(new UnsupportedOperationException("unifiedCompletionInfer not supported")); // TODO
134+
}
135+
125136
private StreamingChatCompletionResults makeResults(List<String> input) {
126137
var responseIter = input.stream().map(String::toUpperCase).iterator();
127138
return new StreamingChatCompletionResults(subscriber -> {
Lines changed: 8 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,7 @@
1212
import org.elasticsearch.core.Nullable;
1313
import org.elasticsearch.test.ESTestCase;
1414
import org.elasticsearch.xcontent.XContentType;
15+
import org.elasticsearch.xpack.inference.external.http.sender.UnifiedChatInput;
1516
import org.elasticsearch.xpack.inference.services.openai.completion.OpenAiChatCompletionModelTests;
1617

1718
import java.io.IOException;
@@ -20,13 +21,13 @@
2021
import java.util.Map;
2122

2223
import static org.elasticsearch.xpack.inference.external.http.Utils.entityAsMap;
23-
import static org.elasticsearch.xpack.inference.external.request.openai.OpenAiChatCompletionRequest.buildDefaultUri;
24+
import static org.elasticsearch.xpack.inference.external.request.openai.OpenAiUnifiedChatCompletionRequest.buildDefaultUri;
2425
import static org.elasticsearch.xpack.inference.external.request.openai.OpenAiUtils.ORGANIZATION_HEADER;
2526
import static org.hamcrest.Matchers.aMapWithSize;
2627
import static org.hamcrest.Matchers.instanceOf;
2728
import static org.hamcrest.Matchers.is;
2829

29-
public class OpenAiChatCompletionRequestTests extends ESTestCase {
30+
public class OpenAiUnifiedChatCompletionRequestTests extends ESTestCase {
3031

3132
public void testCreateRequest_WithUrlOrganizationUserDefined() throws IOException {
3233
var request = createRequest("www.google.com", "org", "secret", "abc", "model", "user");
@@ -75,7 +76,7 @@ public void testCreateRequest_WithDefaultUrlAndWithoutUserOrganization() throws
7576
assertThat(httpRequest.httpRequestBase(), instanceOf(HttpPost.class));
7677
var httpPost = (HttpPost) httpRequest.httpRequestBase();
7778

78-
assertThat(httpPost.getURI().toString(), is(OpenAiChatCompletionRequest.buildDefaultUri().toString()));
79+
assertThat(httpPost.getURI().toString(), is(OpenAiUnifiedChatCompletionRequest.buildDefaultUri().toString()));
7980
assertThat(httpPost.getLastHeader(HttpHeaders.CONTENT_TYPE).getValue(), is(XContentType.JSON.mediaType()));
8081
assertThat(httpPost.getLastHeader(HttpHeaders.AUTHORIZATION).getValue(), is("Bearer secret"));
8182
assertNull(httpPost.getLastHeader(ORGANIZATION_HEADER));
@@ -101,7 +102,7 @@ public void testCreateRequest_WithStreaming() throws URISyntaxException, IOExcep
101102
public void testTruncate_DoesNotReduceInputTextSize() throws URISyntaxException, IOException {
102103
var request = createRequest(null, null, "secret", "abcd", "model", null);
103104
var truncatedRequest = request.truncate();
104-
assertThat(request.getURI().toString(), is(OpenAiChatCompletionRequest.buildDefaultUri().toString()));
105+
assertThat(request.getURI().toString(), is(OpenAiUnifiedChatCompletionRequest.buildDefaultUri().toString()));
105106

106107
var httpRequest = truncatedRequest.createHttpRequest();
107108
assertThat(httpRequest.httpRequestBase(), instanceOf(HttpPost.class));
@@ -121,7 +122,7 @@ public void testTruncationInfo_ReturnsNull() {
121122
assertNull(request.getTruncationInfo());
122123
}
123124

124-
public static OpenAiChatCompletionRequest createRequest(
125+
public static OpenAiUnifiedChatCompletionRequest createRequest(
125126
@Nullable String url,
126127
@Nullable String org,
127128
String apiKey,
@@ -132,7 +133,7 @@ public static OpenAiChatCompletionRequest createRequest(
132133
return createRequest(url, org, apiKey, input, model, user, false);
133134
}
134135

135-
public static OpenAiChatCompletionRequest createRequest(
136+
public static OpenAiUnifiedChatCompletionRequest createRequest(
136137
@Nullable String url,
137138
@Nullable String org,
138139
String apiKey,
@@ -142,7 +143,7 @@ public static OpenAiChatCompletionRequest createRequest(
142143
boolean stream
143144
) {
144145
var chatCompletionModel = OpenAiChatCompletionModelTests.createChatCompletionModel(url, org, apiKey, model, user);
145-
return new OpenAiChatCompletionRequest(List.of(input), chatCompletionModel, stream);
146+
return new OpenAiUnifiedChatCompletionRequest(UnifiedChatInput.of(List.of(input), stream), chatCompletionModel);
146147
}
147148

148149
}

x-pack/plugin/inference/src/test/java/org/elasticsearch/xpack/inference/services/SenderServiceTests.java

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -27,6 +27,7 @@
2727
import org.elasticsearch.xpack.inference.external.http.sender.HttpRequestSender;
2828
import org.elasticsearch.xpack.inference.external.http.sender.InferenceInputs;
2929
import org.elasticsearch.xpack.inference.external.http.sender.Sender;
30+
import org.elasticsearch.xpack.inference.external.http.sender.UnifiedChatInput;
3031
import org.junit.After;
3132
import org.junit.Before;
3233

@@ -120,6 +121,14 @@ protected void doInfer(
120121

121122
}
122123

124+
@Override
125+
protected void doUnifiedCompletionInfer(
126+
Model model,
127+
UnifiedChatInput inputs,
128+
TimeValue timeout,
129+
ActionListener<InferenceServiceResults> listener
130+
) {}
131+
123132
@Override
124133
protected void doChunkedInfer(
125134
Model model,

0 commit comments

Comments
 (0)