Skip to content

Commit 86e499b

Browse files
committed
Remove batched override and add repeat iterations for CI
1 parent 906bbfc commit 86e499b

File tree

1 file changed

+16
-11
lines changed

1 file changed

+16
-11
lines changed

server/src/internalClusterTest/java/org/elasticsearch/search/aggregations/bucket/TermsDocCountErrorIT.java

Lines changed: 16 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -9,10 +9,13 @@
99

1010
package org.elasticsearch.search.aggregations.bucket;
1111

12+
import com.carrotsearch.randomizedtesting.annotations.Repeat;
13+
1214
import org.elasticsearch.action.index.IndexRequestBuilder;
1315
import org.elasticsearch.action.search.SearchResponse;
1416
import org.elasticsearch.cluster.metadata.IndexMetadata;
1517
import org.elasticsearch.common.settings.Settings;
18+
import org.elasticsearch.core.SuppressForbidden;
1619
import org.elasticsearch.search.SearchService;
1720
import org.elasticsearch.search.aggregations.Aggregator.SubAggCollectionMode;
1821
import org.elasticsearch.search.aggregations.BucketOrder;
@@ -41,6 +44,8 @@
4144
import static org.hamcrest.core.IsNull.notNullValue;
4245

4346
@ESIntegTestCase.SuiteScopeTestCase
47+
@SuppressForbidden(reason = "testing")
48+
@Repeat(iterations = 100)
4449
public class TermsDocCountErrorIT extends ESIntegTestCase {
4550

4651
private static final String STRING_FIELD_NAME = "s_value";
@@ -53,17 +58,17 @@ public static String randomExecutionHint() {
5358

5459
private static int numRoutingValues;
5560

56-
@Before
57-
public void disableBatchedExecution() {
58-
// TODO: it's practically impossible to get a 100% deterministic test with batched execution unfortunately, adjust this test to
59-
// still do something useful with batched execution (i.e. use somewhat relaxed assertions)
60-
updateClusterSettings(Settings.builder().put(SearchService.BATCHED_QUERY_PHASE.getKey(), false));
61-
}
62-
63-
@After
64-
public void resetSettings() {
65-
updateClusterSettings(Settings.builder().putNull(SearchService.BATCHED_QUERY_PHASE.getKey()));
66-
}
61+
// @Before
62+
// public void disableBatchedExecution() {
63+
// // TODO: it's practically impossible to get a 100% deterministic test with batched execution unfortunately, adjust this test to
64+
// // still do something useful with batched execution (i.e. use somewhat relaxed assertions)
65+
// updateClusterSettings(Settings.builder().put(SearchService.BATCHED_QUERY_PHASE.getKey(), false));
66+
// }
67+
//
68+
// @After
69+
// public void resetSettings() {
70+
// updateClusterSettings(Settings.builder().putNull(SearchService.BATCHED_QUERY_PHASE.getKey()));
71+
// }
6772

6873
@Override
6974
public void setupSuiteScopeCluster() throws Exception {

0 commit comments

Comments
 (0)