CR: comment

original-brownbear · original-brownbear · commit 88233b380ebc · 2025-03-06T21:35:16.000+01:00
diff --git a/server/src/main/java/org/elasticsearch/action/search/AbstractSearchAsyncAction.java b/server/src/main/java/org/elasticsearch/action/search/AbstractSearchAsyncAction.java
@@ -135,7 +135,7 @@ abstract class AbstractSearchAsyncAction<Result extends SearchPhaseResult> exten
         }
         this.skippedCount = skipped;
         this.shardsIts = iterators;
-        outstandingShards = new AtomicInteger(shardsIts.size() - skipped);
+        outstandingShards = new AtomicInteger(iterators.size());
         successfulOps = new AtomicInteger(skipped);
         this.shardIterators = iterators.toArray(new SearchShardIterator[0]);
         // we later compute the shard index based on the natural order of the shards

Original file line number	Diff line number	Diff line change
`@@ -135,7 +135,7 @@ abstract class AbstractSearchAsyncAction<Result extends SearchPhaseResult> exten`
`135`	`135`	`}`
`136`	`136`	`this.skippedCount = skipped;`
`137`	`137`	`this.shardsIts = iterators;`
`138`		`- outstandingShards = new AtomicInteger(shardsIts.size() - skipped);`
	`138`	`+ outstandingShards = new AtomicInteger(iterators.size());`
`139`	`139`	`successfulOps = new AtomicInteger(skipped);`
`140`	`140`	`this.shardIterators = iterators.toArray(new SearchShardIterator[0]);`
`141`	`141`	`// we later compute the shard index based on the natural order of the shards`