Skip to content

Commit 89c4af7

Browse files
committed
Address test failures in old-lucene-versions
1 parent c0b6794 commit 89c4af7

File tree

2 files changed

+11
-5
lines changed

2 files changed

+11
-5
lines changed

x-pack/plugin/old-lucene-versions/src/main/java/org/elasticsearch/xpack/lucene/bwc/codecs/index/LegacyDocValuesIterables.java

Lines changed: 9 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -222,24 +222,30 @@ public Iterator<Number> iterator() {
222222

223223
return new Iterator<Number>() {
224224
private boolean nextIsSet;
225+
private int currentIndex = 0;
225226
private long nextOrd;
226227

227228
private void setNext() {
228229
try {
229230
if (nextIsSet == false) {
230231
if (values.docID() == -1) {
231232
values.nextDoc();
233+
currentIndex = 0;
232234
}
233235
while (true) {
234236
if (values.docID() == DocIdSetIterator.NO_MORE_DOCS) {
235237
nextOrd = -1;
236238
break;
237239
}
238-
nextOrd = values.nextOrd();
239-
if (nextOrd != -1) {
240-
break;
240+
if (currentIndex < values.docValueCount()) {
241+
nextOrd = values.nextOrd();
242+
currentIndex++;
243+
if (nextOrd != -1) {
244+
break;
245+
}
241246
}
242247
values.nextDoc();
248+
currentIndex = 0;
243249
}
244250
nextIsSet = true;
245251
}

x-pack/plugin/old-lucene-versions/src/test/java/org/elasticsearch/xpack/lucene/bwc/codecs/lucene54/Lucene54DocValuesFormatTests.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -10,12 +10,12 @@
1010
import com.carrotsearch.randomizedtesting.annotations.ThreadLeakFilters;
1111

1212
import org.apache.lucene.codecs.Codec;
13-
import org.apache.lucene.tests.index.BaseDocValuesFormatTestCase;
13+
import org.apache.lucene.tests.index.LegacyBaseDocValuesFormatTestCase;
1414
import org.apache.lucene.tests.util.TestUtil;
1515
import org.elasticsearch.test.GraalVMThreadsFilter;
1616

1717
@ThreadLeakFilters(filters = { GraalVMThreadsFilter.class })
18-
public class Lucene54DocValuesFormatTests extends BaseDocValuesFormatTestCase {
18+
public class Lucene54DocValuesFormatTests extends LegacyBaseDocValuesFormatTestCase {
1919

2020
private final Codec codec = TestUtil.alwaysDocValuesFormat(new Lucene54DocValuesFormat());
2121

0 commit comments

Comments
 (0)