Add comments in all-realms tests (#112627)

Author: gwbrown

x-pack/plugin/security/qa/smoke-test-all-realms/src/javaRestTest/java/org/elasticsearch/xpack/security/authc/SecurityRealmSmokeTestCase.java

@@ -83,9 +83,11 @@ public abstract class SecurityRealmSmokeTestCase extends ESRestTestCase {
         // - AD (configured but won't work because we don't want external fixtures in this test suite)
         .setting("xpack.security.authc.realms.active_directory.ad3.order", "3")
         .setting("xpack.security.authc.realms.active_directory.ad3.domain_name", "localhost")
+        // role mappings don't matter, but we need to read the file as part of the test
         .setting("xpack.security.authc.realms.active_directory.ad3.files.role_mapping", "ldap_role_mapping.yml")
         // - PKI (works)
         .setting("xpack.security.authc.realms.pki.pki4.order", "4")
+        // role mappings don't matter, but we need to read the file as part of the test
         .setting("xpack.security.authc.realms.pki.pki4.files.role_mapping", "pki_role_mapping.yml")
         // - SAML (configured but won't work because we don't want external fixtures in this test suite)
         .setting("xpack.security.authc.realms.saml.saml5.order", "5")

x-pack/plugin/security/qa/smoke-test-all-realms/src/javaRestTest/resources/ldap_role_mapping.yml

@@ -1,4 +1,4 @@
-# AD Realm Role Mapping
+# AD Realm Role Mapping - not actually used, we just want some valid file content.
 group_role:
   - "CN=Avengers,CN=users,DC=ad,DC=test,DC=elasticsearch,DC=com"
 user_role:

x-pack/plugin/security/qa/smoke-test-all-realms/src/javaRestTest/resources/pki_role_mapping.yml

@@ -1,4 +1,4 @@
-# Role mappings for PKI tests
+# Role mappings for PKI tests - not actually used, we just want some valid file content.
 
 user:
   - "CN=Elasticsearch Test Node, OU=elasticsearch, O=org"